Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added multipath enhancement #3

Conversation

nickolasjadams
Copy link
Contributor

@nickolasjadams nickolasjadams commented Nov 19, 2020

I came across a situation that needed my control panel javascript to be separate files so I could perform io on one of them via a script more cleanly. I feel like this might be helpful to others in organizing multiple large additions to the control panel.

Multiple JS filepaths can now be added by delimiting
the paths with a comma

Example
cdn-website/path, /jscp2.js

P.S. That sha1 cachebuster bit is brilliant!

Multiple JS filepaths can now be added by delimiting
the paths with a comma

Example
/js/cp1.js, /jscp2.js
@nickolasjadams
Copy link
Contributor Author

@lindseydiloreto
Not sure if Github has notified you guys of this or not. :)

@lindseydiloreto lindseydiloreto changed the base branch from v2 to v2-dev December 18, 2020 18:01
@lindseydiloreto lindseydiloreto merged commit 4e03b9b into doublesecretagency:v2-dev Dec 18, 2020
@lindseydiloreto
Copy link
Collaborator

Hi @nickolasjadams, sorry for the late reply! I did indeed get notified, it was just a matter of prioritization. I finally got around to looking at this, in part due to a nudge by a similar FR on the CP CSS repo.

Thanks for adding this feature, it's very helpful! I rolled the new functionality into the CP CSS plugin as well, to maintain parity between the two. It's now available in v2.3 of both plugins. 🍺

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants