Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Migrate to stylelint@16 #59

Merged
merged 3 commits into from
Dec 13, 2023
Merged

Migrate to stylelint@16 #59

merged 3 commits into from
Dec 13, 2023

Conversation

@katydecorah katydecorah requested a review from jsnmrs December 12, 2023 02:01
Copy link

@jsnmrs jsnmrs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! Confirming tests pass locally. I added a small commit with the result of npm audit fix, since this is getting other dependency updates.

@jsnmrs
Copy link

jsnmrs commented Dec 13, 2023

@katydecorah I'll leave this one for you to merge since I added a commit along the way

@katydecorah katydecorah merged commit fa67154 into main Dec 13, 2023
1 check passed
@katydecorah katydecorah deleted the stylelint-16 branch December 13, 2023 19:45
@carlosjeurissen
Copy link

When used alongside stylelint 16, I run in the following issue:
exports is not defined in ES module scope This file is being treated as an ES module because it has a '.js' file extension and '/@[email protected][email protected]/node_modules/@double-great/stylelint-a11y/package.json' contains "type": "module". To treat it as a CommonJS script, rename it to use the '.cjs' file extension.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants