Fix player not showing subttile on Mp3 track #337
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #337 +/- ##
======================================
Coverage 99.9% 99.9%
======================================
Files 86 86
Lines 2476 2476
Branches 620 620
======================================
Hits 2472 2472
Misses 4 4 📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
|
I understand why there are no tests for this change, because the bug is within the videojs package. However, when you tested this in vtms, did you test with an mp3 and an audio-only mp4? |
I have tested with Mp3, but after seen your comment I generated a MP4 without video stream using FFMPEG and tested it and it works fine also |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This was an issue with video.js which is fixed in that PR videojs/video.js#7918, and added to that version v7.20.3
So PR is to use the version with fix
Veirfied against vtms
https://dotsub.atlassian.net/browse/DSD-1135