Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix marshalling of StringBuilder errors #533

Merged
merged 7 commits into from
Oct 8, 2024

Conversation

kayoub5
Copy link
Collaborator

@kayoub5 kayoub5 commented Sep 15, 2024

Fixes #532
@trivalik Please test and let me know.

@kayoub5 kayoub5 changed the title Fix marshalling of StringBuilder errors. Fix #532 Fix marshalling of StringBuilder errors. Sep 15, 2024
@kayoub5 kayoub5 changed the title Fix marshalling of StringBuilder errors. Fix marshalling of StringBuilder errors Sep 15, 2024
Copy link

codecov bot commented Sep 15, 2024

Codecov Report

Attention: Patch coverage is 79.31034% with 6 lines in your changes missing coverage. Please review.

Project coverage is 81.25%. Comparing base (2fff830) to head (3b1b506).
Report is 1 commits behind head on master.

Files with missing lines Patch % Lines
SharpPcap/LibPcap/PcapInterface.cs 40.00% 3 Missing ⚠️
SharpPcap/LibPcap/LibPcapLiveDevice.cs 66.66% 2 Missing ⚠️
SharpPcap/LibPcap/CaptureFileReaderDevice.cs 50.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master     #533      +/-   ##
==========================================
- Coverage   81.48%   81.25%   -0.24%     
==========================================
  Files          51       51              
  Lines        2825     2811      -14     
  Branches      310      307       -3     
==========================================
- Hits         2302     2284      -18     
- Misses        421      430       +9     
+ Partials      102       97       -5     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@kayoub5 kayoub5 requested a review from trivalik October 4, 2024 08:02
Copy link
Contributor

@trivalik trivalik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I can't undererstand why not remove the not used using-directives, but ok, for final outcome does it not matter.

@kayoub5 kayoub5 merged commit 5bf70ce into master Oct 8, 2024
9 of 11 checks passed
@kayoub5 kayoub5 deleted the hotfix/stringbuilder_marshall branch October 8, 2024 06:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Error buffer always empty
2 participants