Fix getting block dependencies for function blocks using DBs #194
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
ryan2445
commented
Oct 21, 2023
•
ryan2445
commented
- Makes sure the block name and DB# get added to the dependencies list for function blocks that use a DB
- I wanted to use GetBlockBytes to get some of the block data without parsing everything upfront (some large blocks take a little while) so I made GetBlockBytes a public function. Hopefully that's ok :)
- Fixes an index out of range error while getting step7 v5 project description
ryan2445
commented
Oct 21, 2023
Comment on lines
+649
to
+654
| if (paras.Length > 0) | ||
| { | ||
| var byteAdr = int.Parse(paras[1].Replace("DBX", "").Replace("DBB", "").Replace("DBW", "").Replace("DBD", "")); | ||
| // var byteAdr = int.Parse(paras[1].Replace("DBX", "").Replace("DBB", "").Replace("DBW", "").Replace("DBD", "")); | ||
|
|
||
| var bitAdr = 0; | ||
| if (paras.Length > 2) bitAdr = int.Parse(paras[2]); | ||
| // var bitAdr = 0; | ||
| // if (paras.Length > 2) bitAdr = int.Parse(paras[2]); |
There was a problem hiding this comment.
this code wasn't being used and was causing an error on a few data blocks so just commenting it for now
also checking .Length > 0 since we're only accessing index 0 in paras
|
looks good to me. thx. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.