Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

weird timestamps fixed #155

Merged
merged 1 commit into from
Nov 4, 2020
Merged

weird timestamps fixed #155

merged 1 commit into from
Nov 4, 2020

Conversation

englbit
Copy link
Contributor

@englbit englbit commented Nov 3, 2020

Weird timestamps occur when we add a zero instead of a blanc

Weird timestamps occur when we add a zero instead of a blanc
@jogibear9988
Copy link
Member

this had nothing to do with a blank.
the last parameter of GetDT is not interpred as string. 0x20 adds 32 days

@jogibear9988
Copy link
Member

maybe the string in the database is trimed, so sapces at the end are removed, wich results in a removed space?

@jogibear9988
Copy link
Member

jogibear9988 commented Nov 3, 2020

is it correct that without your patch the timestamps are wrong about 32 days?

@englbit
Copy link
Contributor Author

englbit commented Nov 4, 2020

can't tell if its exactly 32 days, but without this patch timestamps are off, if the string from dbf has a length of 5
Did a lot of testing at this one, because main reason for using your lib is automated block comparing :)

I can check if it's 32 days if you want

//edit:
you are right, they are off by exactly 32 days

@jogibear9988 jogibear9988 merged commit a5c37a9 into dotnetprojects:master Nov 4, 2020
@jogibear9988
Copy link
Member

thanks

@englbit
Copy link
Contributor Author

englbit commented Nov 4, 2020

I thank you for this great library ;)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants