Get CPU ordernumber (MLFB) from CPUFolders. #152
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Attempt at reading out the MLFB from *.s7h files in the "s7hstatx" folder. The byte sequence that define the position of the MLFB string in the file appear to be different among PLC types, thus the different seqeuences are all tested against. However, there may be more sequences that should be added, but it must be tested with more Step7 projects. Currently tested with 7 different CPU types. Probably there is another way to identify the location of the MLFB string that is more deterministic than this pragmatic method. Hopefully someone will find that way. Another weakness with this method is that for one out of 35 projects tested, the s7h file did not exist. Only after a HWConfig recompile was it created. Maybe it was last compiled by on old Step7 version, or there have been an error of some kind.
|
would it be possible to wrap this in a try/catch? if somthing goes wrong, it would be good if we don't break existing code |
|
Sure, comitted it now. |
|
thanks |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Attempt at reading out the MLFB from *.s7h files in the "s7hstatx" folder.
The byte sequence that define the position of the MLFB string in the file
appear to be different among PLC types, thus the different seqeuences
are all tested against. However, there may be more sequences that should
be added, but it must be tested with more Step7 projects. Currently tested
with 7 different CPU types.
Probably there is another way to identify the location of the MLFB string
that is more deterministic than this pragmatic method. Hopefully someone
will find that way.
Another weakness with this method is that for one out of 35 projects tested,
the s7h file did not exist. Only after a HWConfig recompile was it created.
Maybe it was last compiled by on old Step7 version, or there have been
an error of some kind.