Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enable BinSkim scan in nightly validation #8016

Merged

Conversation

MilenaHristova
Copy link
Member

@MilenaHristova MilenaHristova commented Jul 11, 2023

Description

Enabling BinSkim scan over build artifacts in Validate-DotNet pipeline and the .NET staging pipeline based on company requirements.

We are required to run SDL tools on official builds and implement automated bug filling for the tools output. Currently we are running SDL checks over the source code in the nightly builds and in the .NET staging pipeline, but to be compliant we need to also run BinSkim over the produced artifacts.

This PRs is enabling BinSkim checks in the nightly run of Validate-DotNet pipeline.

More information is in the Automate BinSkim runs over official builds issue

Microsoft Reviewers: Open in CodeFlow

@MilenaHristova MilenaHristova requested a review from a team as a code owner July 11, 2023 12:27
@ghost ghost assigned MilenaHristova Jul 11, 2023
@ghost ghost added the PR metadata: Label to tag PRs, to facilitate with triage label Jul 11, 2023
@ghost ghost requested review from dipeshmsft and singhashish-wpf July 11, 2023 12:28
@MilenaHristova MilenaHristova merged commit 019349e into dotnet:main Jul 13, 2023
@MilenaHristova MilenaHristova deleted the mhristova/enable-binskim-scan branch July 13, 2023 15:34
@ghost ghost locked as resolved and limited conversation to collaborators Aug 13, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
PR metadata: Label to tag PRs, to facilitate with triage
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants