-
Notifications
You must be signed in to change notification settings - Fork 1.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Setting IncludePackageReferencesDuringMarkupCompilation with a custom BaseIntermediateOutputPath causes build to fail #4067
Comments
Hi @nick-beer Apologies for the messaging on this feature. The path changes were separated from the source generator support to meet the risk bar for 5.0.2 servicing, but were added back as an opt-in feature for 5.0.3. The changes are in master and will be in 5.0.3 when it ships. Thanks. |
@ryalanms - thanks for the information. I'll be looking forward to 5.0.3. Glad to hear it won't matter long term, but in the meantime I was able to move forward by making the intermediate output path for the WPF inner build match that of the standard build.
|
Please reactivate if you see any issues with 5.0.3. Thanks. |
@ryalanms - I'm still seeing this with sdk 5.0.201, but I'm not able to reopen this issue. I've created a simple set of projects that reproduce the issue - you can get it here. |
Includes a workaround for dotnet/wpf#4067.
Includes a workaround for dotnet/wpf#4067.
Includes a workaround for dotnet/wpf#4067.
Includes a workaround for dotnet/wpf#4067.
Problem description:
I tried following the suggestion in #3963 in order to pull in a source generator nuget to a wpf project. Upon doing so (setting
IncludePackageReferencesDuringMarkupCompilation
totrue
), my build fails with the following:I noticed that if I stop using a custom
BaseIntermediateOutputPath
for my projects, then I'm able to build successfully.Expected behavior:
I should be able to use source generators with wpf applications and use a custom
BaseIntermediateOutputPath
Minimal repro:
IncludePackageReferencesDuringMarkupCompilation
property to be trueDirectory.Build.props
file to setBaseIntermediateOutputPath
. I used..\Objects\$(MSBuildProjectName)
The text was updated successfully, but these errors were encountered: