Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use LibraryImport in some Interop User32 #7172

Merged
merged 1 commit into from
Jun 8, 2022
Merged

Use LibraryImport in some Interop User32 #7172

merged 1 commit into from
Jun 8, 2022

Conversation

gpetrou
Copy link
Contributor

@gpetrou gpetrou commented May 13, 2022 •
edited by ghost
Loading

Now that dotnet/runtime#60595 is closed, perhaps we could start using LibraryImport instead of DllImport.

Proposed changes

  • Use LibraryImport in some Interop User32.
Microsoft Reviewers: Open in CodeFlow

@gpetrou gpetrou requested a review from a team as a code owner May 13, 2022 04:59
@ghost ghost assigned gpetrou May 13, 2022
@kant2002 kant2002 mentioned this pull request May 14, 2022
Closed
1 task
@gpetrou gpetrou force-pushed the User32LibraryImport branch from 944ba0b to c2a1ba2 Compare May 15, 2022 06:18
RussKie
RussKie reviewed May 16, 2022
View reviewed changes
Copy link
Member

@RussKie RussKie left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 LGTM

@RussKie RussKie requested a review from JeremyKuhne May 16, 2022 02:06
@RussKie RussKie added the waiting-on-team This work item needs to be discussed with team or is waiting on team action in order to proceed label May 16, 2022
@gpetrou
Copy link
Contributor Author

gpetrou commented May 24, 2022

@JeremyKuhne any thoughts on this PR? Could we merge it as it is and continue work on subsequent PRs?

@kant2002 kant2002 mentioned this pull request May 30, 2022
Closed
@gpetrou gpetrou force-pushed the User32LibraryImport branch from c2a1ba2 to 5a95d59 Compare May 30, 2022 19:05
@gpetrou gpetrou force-pushed the User32LibraryImport branch from 5a95d59 to 3eb1825 Compare June 5, 2022 17:53
JeremyKuhne
JeremyKuhne approved these changes Jun 8, 2022
View reviewed changes
Copy link
Member

@JeremyKuhne JeremyKuhne left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Took another look. @gpetrou, thanks for doing this, and thanks for your patience.

@JeremyKuhne JeremyKuhne merged commit 86eff93 into dotnet:main Jun 8, 2022
@ghost ghost added this to the 7.0 Preview6 milestone Jun 8, 2022
@RussKie
Copy link
Member

RussKie commented Jun 9, 2022

Thank you all

@gpetrou gpetrou deleted the User32LibraryImport branch June 9, 2022 04:25
@RussKie RussKie added enhancement Product code improvement that does NOT require public API changes/additions and removed waiting-on-team This work item needs to be discussed with team or is waiting on team action in order to proceed labels Jun 10, 2022
@ghost ghost locked as resolved and limited conversation to collaborators Jul 10, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@dreddy-work dreddy-work dreddy-work left review comments

@AaronRobinsonMSFT AaronRobinsonMSFT AaronRobinsonMSFT left review comments

@RussKie RussKie RussKie left review comments

@jkoritzinsky jkoritzinsky jkoritzinsky left review comments

@JeremyKuhne JeremyKuhne JeremyKuhne approved these changes

Assignees

@gpetrou gpetrou

Labels
enhancement Product code improvement that does NOT require public API changes/additions
Projects
None yet
Milestone
7.0 Preview6
Development

Successfully merging this pull request may close these issues.
6 participants
@gpetrou @RussKie @jkoritzinsky @JeremyKuhne @AaronRobinsonMSFT @dreddy-work