suppress nuget package generation warnings NU5131 and NU5128 #2373
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JuditRose
approved these changes
Nov 14, 2019
|
Manually is really the only way that I know of, unless we create a bug in our own repo that references the other one. |
|
(For context, our packages are generating just fine and are being consumed just fine. They have added some warnings to nuget package generation that we're hitting and they are blowing up our build. I'm trying to fix one of them the correct way, but the other one is a bug and needs to be suppressed for our builds to pass) |
|
Going to merge this in since my local build is now passing and our current CI build is broken. |
Codecov Report
@@ Coverage Diff @@
## master #2373 +/- ##
===================================================
- Coverage 28.52174% 28.28163% -0.24011%
===================================================
Files 991 991
Lines 259048 259048
Branches 36816 36816
===================================================
- Hits 73885 73263 -622
- Misses 180323 180968 +645
+ Partials 4840 4817 -23
|
mmitche
pushed a commit
to mmitche/winforms
that referenced
this pull request
Nov 22, 2019
mmitche
added a commit
that referenced
this pull request
Nov 22, 2019
mmitche
pushed a commit
to mmitche/winforms
that referenced
this pull request
Nov 22, 2019
mmitche
added a commit
that referenced
this pull request
Nov 22, 2019
ghost
locked as resolved and limited conversation to collaborators
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed changes
Customer Impact
Regression?
Risk
Test methodology
Microsoft Reviewers: Open in CodeFlow