Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cleanup Menu related interop #1978

Merged
2 commits merged into from
Oct 10, 2019
Merged

Cleanup Menu related interop #1978

2 commits merged into from
Oct 10, 2019

Conversation

hughbe
Copy link
Contributor

@hughbe hughbe commented Sep 26, 2019

Proposed Changes

  • Cleanup Menu related interop
  • Add some menu tests
Microsoft Reviewers: Open in CodeFlow

@hughbe hughbe requested a review from a team as a code owner September 26, 2019 13:45
@codecov
Copy link

codecov bot commented Sep 26, 2019

Codecov Report

Merging #1978 into master will increase coverage by 0.04908%.
The diff coverage is 55.10204%.

@@                Coverage Diff                 @@
##              master      #1978         +/-   ##
==================================================
+ Coverage   27.65681%   27.7059%   +0.04909%     
==================================================
  Files            879        889         +10     
  Lines         266701     266723         +22     
  Branches       37945      37944          -1     
==================================================
+ Hits           73761      73898        +137     
+ Misses        187720     187603        -117     
- Partials        5220       5222          +2
Flag Coverage Δ
#Debug 27.7059% <55.10204%> (+0.04908%) ⬆️
#production 27.7059% <55.10204%> (+0.04908%) ⬆️
#test 100% <ø> (ø) ⬆️

@hughbe hughbe force-pushed the EnableMenuItem branch 2 times, most recently from 9c403e0 to effdc45 Compare October 2, 2019 16:25
@hughbe hughbe force-pushed the EnableMenuItem branch 2 times, most recently from 95453ef to 41e1bbe Compare October 4, 2019 15:02
@zsd4yr
Copy link
Contributor

zsd4yr commented Oct 10, 2019

@msftbot please merge if @RussKie approves

@ghost
Copy link

ghost commented Oct 10, 2019

Hello @zsd4yr!

Because you've given me some instructions on how to help merge this pull request, I'll be modifying my merge approach. Here's how I understand your requirements for merging this pull request:

  • I'll only merge this pull request if it's approved by @RussKie

If this doesn't seem right to you, you can tell me to cancel these instructions and use the auto-merge policy that has been configured for this repository. Try telling me "forget everything I just told you".

@ghost ghost added the :octocat: automerge label Oct 10, 2019
@ghost ghost merged commit 8bc645c into dotnet:master Oct 10, 2019
@RussKie RussKie added code cleanup cleanup code for unused apis/properties/comments - no functional changes. enhancement Product code improvement that does NOT require public API changes/additions labels Oct 10, 2019
@RussKie RussKie added this to the 5.0 milestone Oct 10, 2019
@hughbe hughbe deleted the EnableMenuItem branch October 11, 2019 06:23
@ghost ghost locked as resolved and limited conversation to collaborators Feb 4, 2022
This pull request was closed.
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
code cleanup cleanup code for unused apis/properties/comments - no functional changes. enhancement Product code improvement that does NOT require public API changes/additions :octocat: automerge
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants