[release/9.0] Bump Microsoft.Private.Intellisense to 20241010.1 #12307
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
|
cc: @carlossanlop |
carlossanlop
approved these changes
Oct 10, 2024
There was a problem hiding this comment.
LGTM thanks!
Does this repo depend on source-build-reference-packages? If it does, you might see the same CI failures that we're seeing in runtime (which should go away soon after we merge the deps PR flow): dotnet/runtime#108766 (comment)
I don't think so. We don't receive dependency updates from source-build-reference-packages |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## release/9.0 #12307 +/- ##
=====================================================
+ Coverage 74.81278% 74.81532% +0.00253%
=====================================================
Files 3022 3022
Lines 630157 630157
Branches 46787 46787
=====================================================
+ Hits 471438 471454 +16
+ Misses 155335 155322 -13
+ Partials 3384 3381 -3
Flags with carried forward coverage won't be shown. Click here to find out more. |
Tanya-Solyanik
approved these changes
Oct 11, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Backport of #12306 to release/9.0
/cc @lonitra
Tell mode - Updates to consume latest docs from dotnet-api-docs for RC2. This is an infrastructure only change so risk is low.
Microsoft Reviewers: Open in CodeFlow