Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert PR_9884 “Migrate HtmlHelp to CsWin32” and add unit test #10435

Merged
merged 2 commits into from
Dec 13, 2023

Conversation

Epica3055
Copy link
Member

@Epica3055 Epica3055 commented Dec 6, 2023

Fixes #10410

Related to PR_9884

The issue resulted from PR_9884

Proposed changes

  • Revert PR
  • Add unit test

@ghost ghost assigned Epica3055 Dec 6, 2023
@ghost ghost added the draft draft PR label Dec 6, 2023
@Epica3055 Epica3055 changed the title Revert PR_9884 "Migrate HtmlHelp to CsWin32" and add unit test Revert PR_9884 “Migrate HtmlHelp to CsWin32” and add unit test Dec 6, 2023
@Epica3055 Epica3055 marked this pull request as ready for review December 6, 2023 06:06
@Epica3055 Epica3055 requested a review from a team as a code owner December 6, 2023 06:06
@ghost ghost removed the draft draft PR label Dec 6, 2023
@lonitra
Copy link
Member

lonitra commented Dec 6, 2023

To confirm, was this issue with the metadata?

@lonitra lonitra added the 📭 waiting-author-feedback The team requires more information from the author label Dec 6, 2023
public class HelpTests
{
[Fact]
public void ShowHelpTest()
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Epica3055 - this is the minimal test. Could you please add more coverage?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Epica3055 - this is the minimal test. Could you please add more coverage?

@Tanya-Solyanik Yeah sure.
I think there are three methods should be tested.
But not all of them involve using native dll. This one I wrote here definitely involves using that ( I ran this test before and after the PR ). So I guess maybe this one is enough?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

for example when I write one like this

    [Fact]
    public void ShowHelpTest()
    {
        Help.ShowHelp(null, "https://www.microsoft.com/");
    }

it doesn't involve using native dll.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I see, you are right, for this issue, one is enough. However we need code coverage for all methods on this control eventually. I thought that once you are working in this space, it's easy to add more tests.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This Help is like a general method, not for a specific Control.

8.0-testresult.mp4

I guess this issue can track all Control tests.

@Tanya-Solyanik
Copy link
Member

To confirm, was this issue with the metadata?

Yes, metadata is already fixed, thanks to Lachlan, do we know how much time it would take to update metadata and Win32?

@elachlan
Copy link
Contributor

elachlan commented Dec 6, 2023

Can happen in a day or so depending on the teams.

@ghost ghost removed the 📭 waiting-author-feedback The team requires more information from the author label Dec 7, 2023
@Tanya-Solyanik Tanya-Solyanik added the 📭 waiting-author-feedback The team requires more information from the author label Dec 8, 2023
@Tanya-Solyanik
Copy link
Member

If the new metadata is not published by the middle of the next week, we'll merge this PR and re-open #9884

@Epica3055
Copy link
Member Author

If the new metadata is not published by the middle of the next week, we'll merge this PR and re-open #9884

@Tanya-Solyanik yeah, no problem.

@ghost ghost removed the 📭 waiting-author-feedback The team requires more information from the author label Dec 11, 2023
@Epica3055 Epica3055 merged commit dbc7ce3 into dotnet:main Dec 13, 2023
9 checks passed
@ghost ghost added this to the 9.0 Preview1 milestone Dec 13, 2023
@github-actions github-actions bot locked and limited conversation to collaborators Jan 12, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

HelpProvider unable to load DLL 'htmlhelp.dll' or one of its dependencies
4 participants