-
Notifications
You must be signed in to change notification settings - Fork 54
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[main] Update dependencies from dotnet/wpf #4459
[main] Update dependencies from dotnet/wpf #4459
Conversation
Microsoft.DotNet.Wpf.GitHub , Microsoft.DotNet.Wpf.ProjectTemplates , Microsoft.NET.Sdk.WindowsDesktop From Version 9.0.0-preview.6.24317.1 -> To Version 9.0.0-preview.6.24317.2 Dependency coherency updates Microsoft.Private.Winforms,Microsoft.Internal.Runtime.WindowsDesktop.Transport,Microsoft.Private.Winforms,Microsoft.NETCore.App.Ref,Microsoft.Private.Winforms,VS.Redist.Common.NetCore.SharedFramework.x64.9.0,Microsoft.Private.Winforms,Microsoft.NETCore.App.Runtime.win-x64,Microsoft.Dotnet.WinForms.ProjectTemplates,Microsoft.Private.Winforms,Microsoft.Win32.Registry.AccessControl,Microsoft.Private.Winforms,Microsoft.Win32.SystemEvents,Microsoft.Private.Winforms,System.CodeDom,Microsoft.Private.Winforms,System.ComponentModel.Composition,Microsoft.Private.Winforms,System.Configuration.ConfigurationManager,Microsoft.Private.Winforms,System.Data.Odbc,Microsoft.Private.Winforms,System.Data.OleDb,Microsoft.Private.Winforms,System.Diagnostics.EventLog,Microsoft.Private.Winforms,System.Diagnostics.PerformanceCounter,Microsoft.Private.Winforms,System.DirectoryServices.AccountManagement,Microsoft.Private.Winforms,System.DirectoryServices.Protocols,Microsoft.Private.Winforms,System.DirectoryServices,Microsoft.Private.Winforms,System.IO.Packaging,Microsoft.Private.Winforms,System.IO.Ports,Microsoft.Private.Winforms,System.Management,Microsoft.Private.Winforms,System.Reflection.Context,Microsoft.Private.Winforms,System.Runtime.Caching,Microsoft.Private.Winforms,System.Security.Cryptography.Pkcs,Microsoft.Private.Winforms,System.Security.Cryptography.ProtectedData,Microsoft.Private.Winforms,System.Security.Cryptography.Xml,Microsoft.Private.Winforms,System.Security.Permissions,Microsoft.Private.Winforms,System.ServiceModel.Syndication,Microsoft.Private.Winforms,System.ServiceProcess.ServiceController,Microsoft.Private.Winforms,System.Speech,Microsoft.Private.Winforms,System.Text.Encoding.CodePages,Microsoft.Private.Winforms,System.Threading.AccessControl,Microsoft.Private.Winforms,System.ComponentModel.Composition.Registration,System.Drawing.Common From Version 9.0.0-preview.6.24317.1 -> To Version 9.0.0-preview.6.24317.4 (parent: Microsoft.DotNet.Wpf.GitHub
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Approved by FabricService.
Notification for subscribed users from https://github.com/dotnet/wpf:@'@dotnet/wpf-developers,@dotnet/dotnet-winforms' Action requested: Please take a look at this failing automated dependency-flow pull request's checks; failures may be related to changes which originated in your repo.
|
@ViktorHofer do you happen to know what to do here? Do we just add the thing this is complaining about to Microsoft.WindowsDesktop.App.Ref.sfxproj and Microsoft.WindowsDesktop.App.Runtime.sfxproj? |
This a build authoring issue in runtime. We have a runtime->windowsdesktop transport package (https://dev.azure.com/dnceng/public/_artifacts/feed/dotnet9-transport/NuGet/Microsoft.Internal.Runtime.WindowsDesktop.Transport/overview/9.0.0-preview.6.24317.2) which is missing the dotnet/runtime#52562 tracks adding validation in runtime to verify that the transport packages are closure complete. We don't have that validation yet. |
Unblocks the windowsdesktop dependency flow. See dotnet/windowsdesktop#4459 (comment)
Submitted dotnet/runtime#103629 |
cc @adamsitnik and @ericstj for awareness |
Microsoft.DotNet.Wpf.GitHub , Microsoft.DotNet.Wpf.ProjectTemplates , Microsoft.NET.Sdk.WindowsDesktop From Version 9.0.0-preview.6.24317.1 -> To Version 9.0.0-preview.6.24317.2 Dependency coherency updates Microsoft.Private.Winforms,Microsoft.Internal.Runtime.WindowsDesktop.Transport,Microsoft.Private.Winforms,Microsoft.NETCore.App.Ref,Microsoft.Private.Winforms,VS.Redist.Common.NetCore.SharedFramework.x64.9.0,Microsoft.Private.Winforms,Microsoft.NETCore.App.Runtime.win-x64,Microsoft.Dotnet.WinForms.ProjectTemplates,Microsoft.Private.Winforms,Microsoft.Win32.Registry.AccessControl,Microsoft.Private.Winforms,Microsoft.Win32.SystemEvents,Microsoft.Private.Winforms,System.CodeDom,Microsoft.Private.Winforms,System.ComponentModel.Composition,Microsoft.Private.Winforms,System.Configuration.ConfigurationManager,Microsoft.Private.Winforms,System.Data.Odbc,Microsoft.Private.Winforms,System.Data.OleDb,Microsoft.Private.Winforms,System.Diagnostics.EventLog,Microsoft.Private.Winforms,System.Diagnostics.PerformanceCounter,Microsoft.Private.Winforms,System.DirectoryServices.AccountManagement,Microsoft.Private.Winforms,System.DirectoryServices.Protocols,Microsoft.Private.Winforms,System.DirectoryServices,Microsoft.Private.Winforms,System.IO.Packaging,Microsoft.Private.Winforms,System.IO.Ports,Microsoft.Private.Winforms,System.Management,Microsoft.Private.Winforms,System.Reflection.Context,Microsoft.Private.Winforms,System.Runtime.Caching,Microsoft.Private.Winforms,System.Security.Cryptography.Pkcs,Microsoft.Private.Winforms,System.Security.Cryptography.ProtectedData,Microsoft.Private.Winforms,System.Security.Cryptography.Xml,Microsoft.Private.Winforms,System.Security.Permissions,Microsoft.Private.Winforms,System.ServiceModel.Syndication,Microsoft.Private.Winforms,System.ServiceProcess.ServiceController,Microsoft.Private.Winforms,System.Speech,Microsoft.Private.Winforms,System.Text.Encoding.CodePages,Microsoft.Private.Winforms,System.Threading.AccessControl,Microsoft.Private.Winforms,System.ComponentModel.Composition.Registration,System.Drawing.Common From Version 9.0.0-preview.6.24317.1 -> To Version 9.0.0-preview.6.24317.4 (parent: Microsoft.DotNet.Wpf.GitHub
) Unblocks the windowsdesktop dependency flow. See dotnet/windowsdesktop#4459 (comment)
Microsoft.DotNet.Wpf.GitHub , Microsoft.DotNet.Wpf.ProjectTemplates , Microsoft.NET.Sdk.WindowsDesktop From Version 9.0.0-preview.6.24317.1 -> To Version 9.0.0-preview.6.24318.1 Dependency coherency updates Microsoft.Private.Winforms,Microsoft.Internal.Runtime.WindowsDesktop.Transport,Microsoft.Private.Winforms,Microsoft.NETCore.App.Ref,Microsoft.Private.Winforms,VS.Redist.Common.NetCore.SharedFramework.x64.9.0,Microsoft.Private.Winforms,Microsoft.NETCore.App.Runtime.win-x64,Microsoft.Dotnet.WinForms.ProjectTemplates,Microsoft.Private.Winforms,Microsoft.Win32.Registry.AccessControl,Microsoft.Private.Winforms,Microsoft.Win32.SystemEvents,Microsoft.Private.Winforms,System.CodeDom,Microsoft.Private.Winforms,System.ComponentModel.Composition,Microsoft.Private.Winforms,System.Configuration.ConfigurationManager,Microsoft.Private.Winforms,System.Data.Odbc,Microsoft.Private.Winforms,System.Data.OleDb,Microsoft.Private.Winforms,System.Diagnostics.EventLog,Microsoft.Private.Winforms,System.Diagnostics.PerformanceCounter,Microsoft.Private.Winforms,System.DirectoryServices.AccountManagement,Microsoft.Private.Winforms,System.DirectoryServices.Protocols,Microsoft.Private.Winforms,System.DirectoryServices,Microsoft.Private.Winforms,System.IO.Packaging,Microsoft.Private.Winforms,System.IO.Ports,Microsoft.Private.Winforms,System.Management,Microsoft.Private.Winforms,System.Reflection.Context,Microsoft.Private.Winforms,System.Runtime.Caching,Microsoft.Private.Winforms,System.Security.Cryptography.Pkcs,Microsoft.Private.Winforms,System.Security.Cryptography.ProtectedData,Microsoft.Private.Winforms,System.Security.Cryptography.Xml,Microsoft.Private.Winforms,System.Security.Permissions,Microsoft.Private.Winforms,System.ServiceModel.Syndication,Microsoft.Private.Winforms,System.ServiceProcess.ServiceController,Microsoft.Private.Winforms,System.Speech,Microsoft.Private.Winforms,System.Text.Encoding.CodePages,Microsoft.Private.Winforms,System.Threading.AccessControl,Microsoft.Private.Winforms,System.ComponentModel.Composition.Registration,System.Drawing.Common From Version 9.0.0-preview.6.24317.1 -> To Version 9.0.0-preview.6.24317.4 (parent: Microsoft.DotNet.Wpf.GitHub
Microsoft.DotNet.Wpf.GitHub , Microsoft.DotNet.Wpf.ProjectTemplates , Microsoft.NET.Sdk.WindowsDesktop From Version 9.0.0-preview.6.24317.1 -> To Version 9.0.0-preview.7.24319.2 Dependency coherency updates Microsoft.Private.Winforms,Microsoft.Internal.Runtime.WindowsDesktop.Transport,Microsoft.Private.Winforms,Microsoft.NETCore.App.Ref,Microsoft.Private.Winforms,VS.Redist.Common.NetCore.SharedFramework.x64.9.0,Microsoft.Private.Winforms,Microsoft.NETCore.App.Runtime.win-x64,Microsoft.Dotnet.WinForms.ProjectTemplates,Microsoft.Private.Winforms,Microsoft.Win32.Registry.AccessControl,Microsoft.Private.Winforms,Microsoft.Win32.SystemEvents,Microsoft.Private.Winforms,System.CodeDom,Microsoft.Private.Winforms,System.ComponentModel.Composition,Microsoft.Private.Winforms,System.Configuration.ConfigurationManager,Microsoft.Private.Winforms,System.Data.Odbc,Microsoft.Private.Winforms,System.Data.OleDb,Microsoft.Private.Winforms,System.Diagnostics.EventLog,Microsoft.Private.Winforms,System.Diagnostics.PerformanceCounter,Microsoft.Private.Winforms,System.DirectoryServices.AccountManagement,Microsoft.Private.Winforms,System.DirectoryServices.Protocols,Microsoft.Private.Winforms,System.DirectoryServices,Microsoft.Private.Winforms,System.IO.Packaging,Microsoft.Private.Winforms,System.IO.Ports,Microsoft.Private.Winforms,System.Management,Microsoft.Private.Winforms,System.Reflection.Context,Microsoft.Private.Winforms,System.Runtime.Caching,Microsoft.Private.Winforms,System.Security.Cryptography.Pkcs,Microsoft.Private.Winforms,System.Security.Cryptography.ProtectedData,Microsoft.Private.Winforms,System.Security.Cryptography.Xml,Microsoft.Private.Winforms,System.Security.Permissions,Microsoft.Private.Winforms,System.ServiceModel.Syndication,Microsoft.Private.Winforms,System.ServiceProcess.ServiceController,Microsoft.Private.Winforms,System.Speech,Microsoft.Private.Winforms,System.Text.Encoding.CodePages,Microsoft.Private.Winforms,System.Threading.AccessControl,Microsoft.Private.Winforms,System.ComponentModel.Composition.Registration,System.Drawing.Common From Version 9.0.0-preview.6.24317.1 -> To Version 9.0.0-preview.6.24318.4 (parent: Microsoft.DotNet.Wpf.GitHub
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Approving my own changes...
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
For what it's worth, looks good to me too, thanks!
DAMN! I didn't realize that System.IO.Hashing is a dependency of System.Formats.Nrbf. So I forgot to include it in the windowsdesktop transport package. Submitted dotnet/runtime#103695 |
Microsoft.DotNet.Wpf.GitHub , Microsoft.DotNet.Wpf.ProjectTemplates , Microsoft.NET.Sdk.WindowsDesktop From Version 9.0.0-preview.6.24317.1 -> To Version 9.0.0-preview.7.24319.2 Dependency coherency updates Microsoft.Private.Winforms,Microsoft.Internal.Runtime.WindowsDesktop.Transport,Microsoft.Private.Winforms,Microsoft.NETCore.App.Ref,Microsoft.Private.Winforms,VS.Redist.Common.NetCore.SharedFramework.x64.9.0,Microsoft.Private.Winforms,Microsoft.NETCore.App.Runtime.win-x64,Microsoft.Dotnet.WinForms.ProjectTemplates,Microsoft.Private.Winforms,Microsoft.Win32.Registry.AccessControl,Microsoft.Private.Winforms,Microsoft.Win32.SystemEvents,Microsoft.Private.Winforms,System.CodeDom,Microsoft.Private.Winforms,System.ComponentModel.Composition,Microsoft.Private.Winforms,System.Configuration.ConfigurationManager,Microsoft.Private.Winforms,System.Data.Odbc,Microsoft.Private.Winforms,System.Data.OleDb,Microsoft.Private.Winforms,System.Diagnostics.EventLog,Microsoft.Private.Winforms,System.Diagnostics.PerformanceCounter,Microsoft.Private.Winforms,System.DirectoryServices.AccountManagement,Microsoft.Private.Winforms,System.DirectoryServices.Protocols,Microsoft.Private.Winforms,System.DirectoryServices,Microsoft.Private.Winforms,System.IO.Packaging,Microsoft.Private.Winforms,System.IO.Ports,Microsoft.Private.Winforms,System.Management,Microsoft.Private.Winforms,System.Reflection.Context,Microsoft.Private.Winforms,System.Runtime.Caching,Microsoft.Private.Winforms,System.Security.Cryptography.Pkcs,Microsoft.Private.Winforms,System.Security.Cryptography.ProtectedData,Microsoft.Private.Winforms,System.Security.Cryptography.Xml,Microsoft.Private.Winforms,System.Security.Permissions,Microsoft.Private.Winforms,System.ServiceModel.Syndication,Microsoft.Private.Winforms,System.ServiceProcess.ServiceController,Microsoft.Private.Winforms,System.Speech,Microsoft.Private.Winforms,System.Text.Encoding.CodePages,Microsoft.Private.Winforms,System.Threading.AccessControl,Microsoft.Private.Winforms,System.ComponentModel.Composition.Registration,System.Drawing.Common From Version 9.0.0-preview.6.24317.1 -> To Version 9.0.0-preview.6.24318.4 (parent: Microsoft.DotNet.Wpf.GitHub
Microsoft.DotNet.Wpf.GitHub , Microsoft.DotNet.Wpf.ProjectTemplates , Microsoft.NET.Sdk.WindowsDesktop From Version 9.0.0-preview.6.24317.1 -> To Version 9.0.0-preview.7.24319.2 Dependency coherency updates Microsoft.Private.Winforms,Microsoft.Internal.Runtime.WindowsDesktop.Transport,Microsoft.Private.Winforms,Microsoft.NETCore.App.Ref,Microsoft.Private.Winforms,VS.Redist.Common.NetCore.SharedFramework.x64.9.0,Microsoft.Private.Winforms,Microsoft.NETCore.App.Runtime.win-x64,Microsoft.Dotnet.WinForms.ProjectTemplates,Microsoft.Private.Winforms,Microsoft.Win32.Registry.AccessControl,Microsoft.Private.Winforms,Microsoft.Win32.SystemEvents,Microsoft.Private.Winforms,System.CodeDom,Microsoft.Private.Winforms,System.ComponentModel.Composition,Microsoft.Private.Winforms,System.Configuration.ConfigurationManager,Microsoft.Private.Winforms,System.Data.Odbc,Microsoft.Private.Winforms,System.Data.OleDb,Microsoft.Private.Winforms,System.Diagnostics.EventLog,Microsoft.Private.Winforms,System.Diagnostics.PerformanceCounter,Microsoft.Private.Winforms,System.DirectoryServices.AccountManagement,Microsoft.Private.Winforms,System.DirectoryServices.Protocols,Microsoft.Private.Winforms,System.DirectoryServices,Microsoft.Private.Winforms,System.IO.Packaging,Microsoft.Private.Winforms,System.IO.Ports,Microsoft.Private.Winforms,System.Management,Microsoft.Private.Winforms,System.Reflection.Context,Microsoft.Private.Winforms,System.Runtime.Caching,Microsoft.Private.Winforms,System.Security.Cryptography.Pkcs,Microsoft.Private.Winforms,System.Security.Cryptography.ProtectedData,Microsoft.Private.Winforms,System.Security.Cryptography.Xml,Microsoft.Private.Winforms,System.Security.Permissions,Microsoft.Private.Winforms,System.ServiceModel.Syndication,Microsoft.Private.Winforms,System.ServiceProcess.ServiceController,Microsoft.Private.Winforms,System.Speech,Microsoft.Private.Winforms,System.Text.Encoding.CodePages,Microsoft.Private.Winforms,System.Threading.AccessControl,Microsoft.Private.Winforms,System.ComponentModel.Composition.Registration,System.Drawing.Common From Version 9.0.0-preview.6.24317.1 -> To Version 9.0.0-preview.6.24318.4 (parent: Microsoft.DotNet.Wpf.GitHub
Microsoft.DotNet.Wpf.GitHub , Microsoft.DotNet.Wpf.ProjectTemplates , Microsoft.NET.Sdk.WindowsDesktop From Version 9.0.0-preview.6.24317.1 -> To Version 9.0.0-preview.7.24320.2 Dependency coherency updates Microsoft.Private.Winforms,Microsoft.Internal.Runtime.WindowsDesktop.Transport,Microsoft.Private.Winforms,Microsoft.NETCore.App.Ref,Microsoft.Private.Winforms,VS.Redist.Common.NetCore.SharedFramework.x64.9.0,Microsoft.Private.Winforms,Microsoft.NETCore.App.Runtime.win-x64,Microsoft.Dotnet.WinForms.ProjectTemplates,Microsoft.Private.Winforms,Microsoft.Win32.Registry.AccessControl,Microsoft.Private.Winforms,Microsoft.Win32.SystemEvents,Microsoft.Private.Winforms,System.CodeDom,Microsoft.Private.Winforms,System.ComponentModel.Composition,Microsoft.Private.Winforms,System.Configuration.ConfigurationManager,Microsoft.Private.Winforms,System.Data.Odbc,Microsoft.Private.Winforms,System.Data.OleDb,Microsoft.Private.Winforms,System.Diagnostics.EventLog,Microsoft.Private.Winforms,System.Diagnostics.PerformanceCounter,Microsoft.Private.Winforms,System.DirectoryServices.AccountManagement,Microsoft.Private.Winforms,System.DirectoryServices.Protocols,Microsoft.Private.Winforms,System.DirectoryServices,Microsoft.Private.Winforms,System.IO.Packaging,Microsoft.Private.Winforms,System.IO.Ports,Microsoft.Private.Winforms,System.Management,Microsoft.Private.Winforms,System.Reflection.Context,Microsoft.Private.Winforms,System.Runtime.Caching,Microsoft.Private.Winforms,System.Security.Cryptography.Pkcs,Microsoft.Private.Winforms,System.Security.Cryptography.ProtectedData,Microsoft.Private.Winforms,System.Security.Cryptography.Xml,Microsoft.Private.Winforms,System.Security.Permissions,Microsoft.Private.Winforms,System.ServiceModel.Syndication,Microsoft.Private.Winforms,System.ServiceProcess.ServiceController,Microsoft.Private.Winforms,System.Speech,Microsoft.Private.Winforms,System.Text.Encoding.CodePages,Microsoft.Private.Winforms,System.Threading.AccessControl,Microsoft.Private.Winforms,System.ComponentModel.Composition.Registration,System.Drawing.Common From Version 9.0.0-preview.6.24317.1 -> To Version 9.0.0-preview.6.24319.5 (parent: Microsoft.DotNet.Wpf.GitHub
This pull request updates the following dependencies
Coherency Updates
The following updates ensure that dependencies with a CoherentParentDependency
attribute were produced in a build used as input to the parent dependency's build.
See Dependency Description Format
From https://github.com/dotnet/wpf