-
Notifications
You must be signed in to change notification settings - Fork 53
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add a profile attribute to files in windows desktop runtime pack #4227
Conversation
Isn't this possible without hardcoding all the assemblies? |
This is mostly following the way target pack does this, and the runtime seems to have more files than the target pack. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't have an understanding of the framework generation logic, but since it sounds like the tooling will validate the list this LGTM. Thanks!
<!-- Windows Forms specific references --> | ||
<ItemGroup> | ||
<FrameworkListFileClass Include="Microsoft.VisualBasic.Forms.dll" Profile="WindowsForms" /> | ||
<FrameworkListFileClass Include="Microsoft.VisualBasic.dll" Profile="WindowsForms" /> | ||
<FrameworkListFileClass Include="System.Design.dll" Profile="WindowsForms" /> | ||
<FrameworkListFileClass Include="System.Drawing.Common.dll" Profile="WindowsForms" /> | ||
<FrameworkListFileClass Include="System.Drawing.Design.dll" Profile="WindowsForms" /> | ||
<FrameworkListFileClass Include="System.Drawing.dll" Profile="WindowsForms" /> | ||
<FrameworkListFileClass Include="System.Windows.Forms.Design.Editors.dll" Profile="WindowsForms" /> | ||
<FrameworkListFileClass Include="System.Windows.Forms.Design.dll" Profile="WindowsForms" /> | ||
<FrameworkListFileClass Include="System.Windows.Forms.Primitives.dll" Profile="WindowsForms" /> | ||
<FrameworkListFileClass Include="System.Windows.Forms.dll" Profile="WindowsForms" /> | ||
<FrameworkListFileClass Include="Microsoft.VisualBasic.Forms.resources.dll" Profile="WindowsForms" /> | ||
<FrameworkListFileClass Include="System.Windows.Forms.Design.resources.dll" Profile="WindowsForms" /> | ||
<FrameworkListFileClass Include="System.Windows.Forms.Primitives.resources.dll" Profile="WindowsForms" /> | ||
<FrameworkListFileClass Include="System.Windows.Forms.resources.dll" Profile="WindowsForms" /> | ||
<FrameworkListFileClass Include="System.Windows.Input.Manipulations.resources.dll" Profile="WindowsForms" /> | ||
<FrameworkListFileClass Include="System.Private.Windows.Core.dll"/> | ||
</ItemGroup> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is an incorrect way of doing this. The Windows Forms items must be imported from System.Windows.Forms.FileClassification.props. If the content of the props file is incorrect then it must be updated: https://github.com/dotnet/winforms/tree/main/pkg/Microsoft.Private.Winforms#sdkdotnet-windowsdesktop-folder
/cc: @lonitra
Adds a profile attribute to the RuntimeList.xml in windows desktop runtime pack, similar to the corresponding target pack. This is needed to fix issue 37088 and PR 39402 has the corresponding SDK fix.
The target pack uses System.Windows.Forms.FileClassification.props but the analyzer assemblies (
System.Windows.Forms.Analyzers.CSharp.dll
,System.Windows.Forms.Analyzers.dll
) causes problems and hence the runtime pack uses the assembly names explicitly. Also, the runtime pack has extra assemblies than the target pack. The assembly,System.Private.Windows.Core.dll
, isn't tagged with a profile.