This repository has been archived by the owner on May 21, 2024. It is now read-only.
Remove unused dependencies #59
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JoeRobich
commented
Mar 30, 2022
| @@ -13,21 +13,21 @@ jobs: | |||
| displayName: 'Install Node.js' | |||
|
|
|||
| - script: | | |||
| npm install | |||
| npm ci | |||
There was a problem hiding this comment.
Use CI instead of install so that packages are installed based on the package-lock ensuring the expected package version and sources are used.
| "vscode-tas-client": "^0.1.17", | ||
| "webpack": "^4.44.1", | ||
| "webpack-cli": "^3.3.12" | ||
| "@types/node": "17.0.23", |
There was a problem hiding this comment.
Use exact versions so that we have better control over which package we are restoring and using. Also removed unused webpack loaders.
| @@ -4,7 +4,7 @@ | |||
| import * as vscode from "vscode"; | |||
| import * as path from "path"; | |||
|
|
|||
| export async function dotnetGettingStartedCmdHandler(context: vscode.ExtensionContext, operationId: string, tabId?: string) { | |||
| export async function dotnetGettingStartedCmdHandler(context: vscode.ExtensionContext) { | |||
There was a problem hiding this comment.
Remove unused parameters to fix linting violation.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.