Merge master into release #601
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This fixes debugger restoration on osx.10.12.
Move OmniSharp-specific code into omnisharp directory
Update vscode and vsce module versions and vscode engine version to latest
Hardcode osx.10.11-x64 for osx runtime id
These package updates turn on conditional breakpoint support at the UI level and step filtering support.
Update MIEngine reference and add step filtering to launch schema
* Update link to .NET Core tools * Fix link
Enabling action pickProcess for attach.
Red Hat Enterprise Linux.
Fixed typo. This is a blocker bug for RHEL users because this extension can't launch.
Update version to 1.3.0 for master branch
In a code path, template processId is 0 instead of command.pickProcess. Fixing it.
Added constructor snippet
Enable razor debugging support
This gives us more control over which RID to use for linux distros.
Previously we were manually parsing the path environment variable which is prone to issue when users $PATH variables are malformed. This should be more robust.
check if dotnet is on $PATH by executing 'dotnet --info'
Determine linux RID's based on etc/os-release rather than dotnet --info
Added Fact xunit snippet
It is no longer necessary to ensure that the workspace root contains a project.json (or global.json) before offering to generate tasks.json and launch.json. When launched, OmniSharp should scan for projects and, if any or found, we'll offer to generate the assets if needed.
1. The diagnostics provider won't refresh diagnostics while the OmniSharp server is restoring packages. Instead, it waits until it receives an event from OmniSharp afterward. However, that event was only expecting the old DNX protocol, so the diagnostics provider never automatically updated after packages were restored. This change gets rid of the DNX protocol and changes the diagnostic provider to look for .NET Core projects. 2. Hidden diagnostics should have DiagnosticSeverity.Info rather DiagnosticSeverity.Warning. 3. When the processing *all* of the diagnostics (not just those for the current file), the previous diagnostics were not cleared out first. This resulted in new diagnostics being merged with old diagnostics, creating duplicates diagnostics. Now we clear the diagnostics for a file before adding new ones.
…supported Linux distro
Improve generation of tasks.json and launch.json assets
Fix several issues with diagnostics
…inux-distro-text Tweak the message displayed when trying to acquire OmniSharp on an unsupported Linux distro
Update version to 1.3.0-beta2
Update coreclr-debug packages for 1.3 release.
…ssue Fix relative path issue in asset generation
…ktop versions of OmniSharp
…-install Fix offline packaging for Windows to include both the CoreCLR and Desktop versions of OmniSharp
Update readme for 1.3
|
@gregg-miskelly, @chuckries, @caslan, @rajkumar42: I scanned through the changes and it looks right to me. Do any of you want to double-check the debugger changes? |
|
@DustinCampbell Yeah, we were going to do a quick smoke test of the .vsix. Do you have one built already? (If not, we can build it) |
|
We should build the final from the release branch. Once I merge, could you build it from there? |
|
That works with me. |
|
look good? |
|
Yup. Merge it. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.