Fixing Roslyn RS2002 errors blocking Arcade builds #1118
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sunandabalu
approved these changes
May 10, 2022
brandonh-msft
force-pushed
the
brandonh/net7-fixes
branch
from
128f086
to
03d703d
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The RS2002 errors that are causing the arcade PR to fail are due to
dotnet/roslyn-analyzers#5890
wherein using the target-typed
new()declaration causes this to fire on you. "Reverting" to explicit ctor usage fixes the issue and allows the PR branch to build w/o issue: