Use UseShellExecute=false for chmod process #2579
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
donJoseLuis
approved these changes
Oct 14, 2020
bekir-ozturk
approved these changes
Oct 14, 2020
src/Microsoft.TemplateEngine.Cli/PostActionProcessors/ChmodPostActionProcessor.cs
Show resolved
Hide resolved
This was referenced Oct 15, 2020
genalt
approved these changes
Oct 15, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Delivers issue #2072.
Related to PR #1555 and issue #1547.
The chmod post-action got broken because
UseShellExecuteoption ofSystem.Diagnostics.Process.Startchanged its meaning from "run /bin/sh" to "run xdg-open" on Linux (and "run open" on Mac OS).PR #1555 partially fixed the problem, but it is needed also to switch the
UseShellExecutefrom true to false and refuse to use this unstable option to completely fix the problem.