Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add HttpRequestBase.Files and supporting types #141

Closed
sdekock opened this issue Aug 11, 2022 · 4 comments · Fixed by #260
Closed

Add HttpRequestBase.Files and supporting types #141

sdekock opened this issue Aug 11, 2022 · 4 comments · Fixed by #260
Milestone

Comments

@sdekock
Copy link
Contributor

sdekock commented Aug 11, 2022

In PR #103 the types to handle file upload were added: Files property on HttpRequest and HttpPostedFile class.

These should also be created in the *Base variants: Files property in HttpRequestBase and a HttpPostedFileBase class.

@sdekock
Copy link
Contributor Author

sdekock commented Aug 11, 2022

To be considered as part of #91 ?

@twsouthwick
Copy link
Member

Let's keep it separate - #91 will be separated out into new issues (all features from that that will be addressed for v1 have been at this point). Can you share the full API shape you want to enable here?

@sdekock
Copy link
Contributor Author

sdekock commented Aug 15, 2022

Can you share the full API shape you want to enable here?

The Files property on the HttpRequestBase class and Files property on the HttpRequestWrapper class
And supporting types:
HttpFileCollectionBase
HttpFileCollectionWrapper
HttpPostedFileBase
HttpPostedFileWrapper

Same functionality that was exposed as per PR #103 on HttpRequest, but then on the *Base variants plus the Wrapper classes.

I already made an attempt of implementing this here: main...sdekock:systemweb-adapters:sdk/requestbase-files
But I have not been able to test it, so I have not yet created a PR. I can finish it if you want to ...

@adityamandaleeka
Copy link
Member

@sdekock Sure, a PR would be welcomed. At this point it likely wouldn't make it into the RC 1 release but we would get it into post-1.0.

@adityamandaleeka adityamandaleeka added this to the Backlog milestone Sep 7, 2022
twsouthwick pushed a commit that referenced this issue Feb 17, 2023
Add missing property of File in HttpRequest.

Fixes #141
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants