Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add missing dependency Microsoft.DotNet.PlatformAbstractions.dll #108

Merged
merged 2 commits into from
Jul 5, 2018
Merged

Add missing dependency Microsoft.DotNet.PlatformAbstractions.dll #108

merged 2 commits into from
Jul 5, 2018

Conversation

tmat
Copy link
Member

@tmat tmat commented Jul 5, 2018 •
edited
Loading

Fixes #107

@tmat tmat merged commit 1a921c7 into master Jul 5, 2018
@tmat tmat deleted the PlatformAbstractions branch July 5, 2018 16:17
@tmat tmat changed the title Add missing Microsoft.DotNet.PlatformAbstractions.dll to net461 Add missing dependency Microsoft.DotNet.PlatformAbstractions.dll Jul 5, 2018
@tmat tmat mentioned this pull request Jul 5, 2018
Closed
@tmat tmat restored the PlatformAbstractions branch July 5, 2018 18:52
tmat added a commit that referenced this pull request Jul 5, 2018
@tmat
Revert "Add missing dependency Microsoft.DotNet.PlatformAbstractions.…
92e9fa6 
…dll (#108)"

This reverts commit 1a921c7.
@tmat tmat mentioned this pull request Jul 5, 2018
Closed
tmat added a commit that referenced this pull request Jul 5, 2018
@tmat
Revert "Add missing dependency Microsoft.DotNet.PlatformAbstractions.…
cca92d9 
…dll (#108)"

This reverts commit 1a921c7.

Realized that this dependency is only needed on Core and it is available in the SDK, so we don't need to include it in the package.
@tmat tmat mentioned this pull request Jul 5, 2018
Merged
tmat added a commit that referenced this pull request Jul 5, 2018
@tmat
Revert "Add missing dependency Microsoft.DotNet.PlatformAbstractions.…
ffd0b68 
…dll (#108)" (#111)

This reverts commit 1a921c7.

Realized that this dependency is only needed on Core and it is available in the SDK, so we don't need to include it in the package.
@tmat tmat deleted the PlatformAbstractions branch December 24, 2018 10:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@tmat