-
Notifications
You must be signed in to change notification settings - Fork 123
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add support for Bitbucket Cloud #31
Comments
So it seems that BitBucket uses the same URL pattern as GitLab. Although we would want to have a Microsoft.SourceLink.BitBucket package for convenience, you should be able to use Microsoft.SourceLink.GitLab package to generate SourceLink for BitBucket as well. I have just published the package on myget: https://dotnet.myget.org/feed/sourcelink/package/nuget/Microsoft.SourceLink.GitLab Could you please try it and confirm it works with BitBucket? Apart from the package reference you'll need to specify host like so: <ItemGroup>
<PackageReference Include="Microsoft.SourceLink.GitLab" Version="1.0.0-beta-63001-01" PrivateAssets="all" />
<SourceLinkGitLabHosts Include="{host-name}" />
</ItemGroup> The If it builds fine and produces *.sourcelink.json in |
@tmat thanks for the head up. Just be aware that Bitbucket server and Bitbucket cloud use different URL patterns, so a change is required to support both types. |
@chris5287 I see. Yes, we will need a specialized one for Server. |
@chris5287 Do you know if there is a public documentation on the format of the URL? |
Example implementation fetching required details from git url: https://github.com/ctaggart/SourceLink/blob/master/SourceLink.Create.BitBucketServer/BitBucketServerUrlConverter.cs Sorry couldn’t find public API documentation via a quick google search. |
The second |
Bitbucket supports both Git and Mercurial. So we'll need to include that in the name: Implementing |
Filed #124 to track Mercurial support. Contributions are welcome. |
I'm gonna create a new issue for Bitbucket Enterprise and rename this to Bitbucket cloud. |
@ctaggart Bitbucket Enterprise has two options: Server and Data Center. Do you know if they use the same URL formats? |
@tmat I do not. All Bitbucket Server stuff was contributed by others. |
@chris5287 contributed it, and he opened the request here. Hopefully, he knows. |
Hahaha, and they are different. That was the first thing he mentioned in this thread.
|
Afraid I only have access to server at work and I have been unable to find any official documentation from atlassian. |
To clarify: let's use this issue to track support for git repos on bitbucket.org. Microsoft.SourceLink.Bitbucket.Git will be available on myget shortly to support this scenario, so I consider this issue resolved. |
The package is available on MyGet now: Microsoft.SourceLink.Bitbucket.Git |
quick question, are private BitBucket repos supported with this and VS 15.7+, package documentation says only private GitHub and VSTS repositories. |
@chuckries Does Bitbucket implement auth that the debugger currently supports? |
@chuckries That isn't out yet though, right? |
@ctaggart It is out in the latest preview: https://visualstudio.microsoft.com/vs/preview/. BitBucket is enabled by default and requires no configuration. There is a new checkbox under Tools -> Options -> Debugging that will allow GCM to be used for any Source Link request. |
@chuckries that great to hear, looking forward to trying it out |
See:
The text was updated successfully, but these errors were encountered: