Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[VMR] [PoC] Do not pass DotNetBuildFromSource when building VMR PoCs #3704

Closed
mmitche opened this issue Nov 1, 2023 · 7 comments
Closed
Assignees

Comments

@mmitche
Copy link
Member

mmitche commented Nov 1, 2023

When building the VMR as Microsoft, we want to a produce a superset of outputs, and allow a superset of inputs from what would be produced out of the Linux build that our distro partners would use.

Right now the VMR build infra passes DotNetBuildFromSource. We need to add a way to not pass this switch. However, some places where this switch is used will be required for the VMR vertical build.

For the VMR PoCs, we should not be passing this switch. The use of DotNetBuildFromSource will not give a full accounting of the PoCs. Instead, we should be passing another placeholder switch (e.g. DotNetBuildVertical), and using this in places where we need for the PoCs.

Copy link

I couldn't figure out the best area label to add to this issue. If you have write-permissions please help me learn by adding exactly one area label.

@mmitche
Copy link
Member Author

mmitche commented Nov 1, 2023

Related to #2974

@mmitche mmitche changed the title [VMR] [PoC} Do not pass DotNetBuildFromSource when building VMR in non distro-partner VMR builds [VMR] [PoC} Do not pass DotNetBuildFromSource when building VMR PoCs Nov 1, 2023
@akoeplinger
Copy link
Member

akoeplinger commented Nov 2, 2023

I also found that we always pass DotNetBuildFromSourceFlavor=Product in the VMR, but we have several checks for != Product in the repos.

Related properties that came up are ArcadeBuildFromSource, ArcadeInnerBuildFromSource and ExcludeFromSourceBuild.

@akoeplinger akoeplinger self-assigned this Nov 2, 2023
@ViktorHofer ViktorHofer changed the title [VMR] [PoC} Do not pass DotNetBuildFromSource when building VMR PoCs [VMR] [PoC] Do not pass DotNetBuildFromSource when building VMR PoCs Nov 2, 2023
@akoeplinger
Copy link
Member

Learned that DotNetBuildFromSourceFlavor=Product is supposed to mean building the whole product (e.g. the source-build/VMR), but individual repos can have CI jobs without that property when building only their slice for validation.

akoeplinger added a commit to dotnet/arcade that referenced this issue Nov 9, 2023
…dFromSource is not true (#14217)

This is required for the VMR build when DotNetBuildFromSource is not set: dotnet/source-build#3704
@ViktorHofer
Copy link
Member

This is now implemented for the Windows VMR build.

@ViktorHofer
Copy link
Member

Related: #3965

@ViktorHofer
Copy link
Member

Closing as completed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: Done
Development

No branches or pull requests

3 participants