Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Future should use VS 2017 #812

Merged
merged 4 commits into from
Feb 4, 2017
Merged

Future should use VS 2017 #812

merged 4 commits into from
Feb 4, 2017

Conversation

ramarag
Copy link
Member

@ramarag ramarag commented Feb 3, 2017

@nguerrera PTAL

some more missing changes in netci.groovy

@ramarag ramarag mentioned this pull request Feb 3, 2017
Merged
333fred
333fred requested changes Feb 3, 2017
View reviewed changes
Copy link
Member

@333fred 333fred left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Remove the .netci.grooy.swp file

@333fred 333fred changed the title Fututre shoulbe 2017 Future should be use VS 2017 Feb 3, 2017
@333fred 333fred changed the title Future should be use VS 2017 Future should use VS 2017 Feb 3, 2017
@dsplaisted @ramarag
Don't set environment variables for VS SDK during CI runs
19641cb 
The VS SDK isn't installed on CI machines
@333fred
Copy link
Member

333fred commented Feb 3, 2017

@ramarag, this isn't going to have any effect on the Jenkins jobs. Jenkins does not pull job definitions from the future branch, only from master.

@ramarag ramarag force-pushed the fututre_shoulbe_2017 branch from 602aab7 to 1a1c295 Compare February 3, 2017 23:33
@ramarag
Copy link
Member Author

ramarag commented Feb 3, 2017

removed the *.swp

@ramarag
Copy link
Member Author

ramarag commented Feb 3, 2017

i don't think future branch CI jobs runs master netci.groovy for proof look at

https://ci.dot.net/job/Private/job/dotnet_sdk/job/future/job/debug_windows_nt_prtest/34/consoleFull
THe CI is not setting SET VS150COMNTOOLS

333fred
333fred approved these changes Feb 3, 2017
View reviewed changes
Copy link
Member

@333fred 333fred left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry, no idea what I was thinking.

@333fred
Copy link
Member

333fred commented Feb 3, 2017

@dotnet-bot test ci please

@ramarag
Copy link
Member Author

ramarag commented Feb 3, 2017

The windows build failure are expected i suppose due to my previous PR with incomplete change #808 has taken effect

@333fred
Copy link
Member

333fred commented Feb 3, 2017

Immediate failure: https://ci.dot.net/job/Private/job/dotnet_sdk/job/future/job/GenPRTest/job/debug_windows_nt_prtest/1/console

@333fred
Copy link
Member

333fred commented Feb 3, 2017

@dotnet-bot test ci please

1 similar comment
@ramarag
Copy link
Member Author

ramarag commented Feb 3, 2017

@dotnet-bot test ci please

@333fred
Copy link
Member

333fred commented Feb 3, 2017

The updated version of Windows_NT Debug finished here: https://ci.dot.net/job/Private/job/dotnet_sdk/job/future/job/GenPRTest/job/debug_windows_nt_prtest/2/ successfully. The full framework test is still running https://ci.dot.net/job/Private/job/dotnet_sdk/job/future/job/GenPRTest/job/debug_windows_nt_fullframework_prtest/1/console

@333fred
Copy link
Member

333fred commented Feb 4, 2017

@ramarag https://ci.dot.net/job/Private/job/dotnet_sdk/job/future/job/GenPRTest/job/debug_windows_nt_fullframework_prtest/1/ finished successfully. You should be good to merge.

@nguerrera
Copy link
Contributor

If this is the reason, maybe just let full merge through and then do a test. Seems better than a mess of history with duplicated commits

@ramarag ramarag merged commit acf87a3 into dotnet:future Feb 4, 2017
mmitche pushed a commit to mmitche/sdk that referenced this pull request Jun 5, 2020
@vijayrkn
Merge pull request dotnet#812 from aspnet/vramak/Update50
22c91fa 
Updating the branding to 5.0
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@333fred 333fred 333fred approved these changes

@nguerrera nguerrera nguerrera approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@ramarag @333fred @nguerrera @dnfclas @dsplaisted