Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

sln-list: Fix char conversions #44661

Merged
merged 1 commit into from
Nov 6, 2024
Merged

sln-list: Fix char conversions #44661

merged 1 commit into from
Nov 6, 2024

Conversation

edvilme
Copy link
Member

@edvilme edvilme commented Nov 5, 2024

@dotnet-issue-labeler dotnet-issue-labeler bot added Area-Infrastructure untriaged Request triage from a team member labels Nov 5, 2024
@edvilme edvilme changed the title Fix chars issue sln-add: Fix char conversions Nov 5, 2024
@edvilme edvilme changed the title sln-add: Fix char conversions sln-list: Fix char conversions Nov 5, 2024
@edvilme edvilme marked this pull request as ready for review November 5, 2024 22:13
@edvilme edvilme requested a review from a team November 5, 2024 22:13
@kasperk81 kasperk81 mentioned this pull request Nov 5, 2024
Merged
eerhardt
eerhardt approved these changes Nov 5, 2024
View reviewed changes
Copy link
Member

@eerhardt eerhardt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. I figured if I add another approval, maybe that will make CI pass faster so this can be merged.

@eerhardt eerhardt enabled auto-merge (squash) November 5, 2024 22:51
@eerhardt eerhardt mentioned this pull request Nov 5, 2024
Merged
@eerhardt eerhardt merged commit ee23b92 into dotnet:main Nov 6, 2024
37 checks passed
edvilme added a commit to edvilme/sdk that referenced this pull request Dec 10, 2024
@edvilme
sln-list: Fix char conversions (dotnet#44661)
d8001f9
@edvilme edvilme mentioned this pull request Dec 10, 2024
Merged
edvilme added a commit to edvilme/sdk that referenced this pull request Dec 11, 2024
@edvilme
sln-list: Fix char conversions (dotnet#44661)
25fd857
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nagilson nagilson nagilson approved these changes

@MiYanni MiYanni MiYanni approved these changes

@eerhardt eerhardt eerhardt approved these changes

Assignees
No one assigned
Labels
Area-Infrastructure untriaged Request triage from a team member
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@edvilme @eerhardt @MiYanni @nagilson