-
Notifications
You must be signed in to change notification settings - Fork 1.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove additional TL characters from the dotnet run output special casing for tests #44442
base: release/9.0.1xx
Are you sure you want to change the base?
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm fine with disabling this test, but the way that it is failing seems to be weird and not very likely to be specific to the 2.1 versions.
Maybe it's an issue with StripTerminalLoggerProgressIndicators
. Any thoughts @baronfel?
Those ESC codes are for making the curor visible/invisible:
The progress indicators are separate - I'm not sure how or why those are appearing for these legs. Nothing in TL itself cares about TFMs so I'm not sure what functionality toggle is being hit here. |
@rainersigwald I think this is an artifact of the TL capability detection stuff too - I think recently @MichalPavlik did some work to make sure TL wouldn't emit some control codes in certain scenarios, but the TL used in |
There's dotnet/msbuild#10678 but that was about making sure we told the Windows console that we were going to emit VT-100. I don't think we've changed anything that should affect this recently, and I don't understand why it'd be intermittent of all things . . . |
I'm not sure why it would show up sometimes but not others but that's definitely the behavior we've seen. Here's a recent run where only one of the four theories for this test failed: |
Add the two additional character removals to see if that solves this instead. |
rename title to |
I've seen this test fail a couple of times in the past week or so and it always seems to pass on rerun. Since I only noticed it failing when targeting 2.1, it didn't seem worth keeping these specific versions of the test around and taking time to investigate. Let me know if you think it's worth investigating.
https://dev.azure.com/dnceng-public/public/_build/results?buildId=852383&view=ms.vss-test-web.build-test-results-tab&runId=22136852&resultId=103685&paneView=debug
Expected string to be equivalent to ".NET Core 2.1" with a length of 13, but "�[?25l�[1F
�[?25h.NET Core 2.1" has a length of 31, differs near "�[?" (index 0).