Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Dotnet test integration (first part) #44268

Open
wants to merge 30 commits into
base: main
Choose a base branch
from
Open

Dotnet test integration (first part) #44268

wants to merge 30 commits into from

Conversation

nohwnd
Copy link
Member

@nohwnd nohwnd commented Oct 17, 2024 •
edited
Loading

Enable view with progress for new dotnet test experience ( that is under the env variable flag )

progress-dotnet-test

Discovery:

image

@nohwnd nohwnd requested a review from a team as a code owner October 17, 2024 11:19
@dotnet-issue-labeler dotnet-issue-labeler bot added Area-DotNet Test untriaged Request triage from a team member labels Oct 17, 2024
nohwnd
nohwnd commented Oct 17, 2024
View reviewed changes
src/Cli/dotnet/Class1.cs Outdated Show resolved Hide resolved
@ViktorHofer
Copy link
Member

Episode IV.V - A New Snack 🤣🤣🤣

@build-analysis build-analysis bot mentioned this pull request Oct 22, 2024
Open
Evangelink
Evangelink reviewed Nov 4, 2024
View reviewed changes
Copy link
Member

@Evangelink Evangelink left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I see many similarities with the class in our new platform. If the 2 classes are supposed to be the same, it could be interesting to have a comment pointing to the commit it relates to.

src/Cli/dotnet/commands/dotnet-test/TestingPlatformCommand.cs Outdated Show resolved Hide resolved
@nohwnd
Copy link
Member Author

nohwnd commented Nov 5, 2024

I see many similarities with the class in our new platform. If the 2 classes are supposed to be the same, it could be interesting to have a comment pointing to the commit it relates to.

which class is The Class? :)

@nohwnd nohwnd changed the title Dotnet test integration Dotnet test integration (first part) Nov 5, 2024
@nohwnd
Copy link
Member Author

nohwnd commented Nov 5, 2024

/azp run

@azure-pipelines Azure Pipelines
Copy link

Azure Pipelines successfully started running 4 pipeline(s).

@mariam-abdulla
Copy link
Member

We are still missing the help option (OnHelpRequested callback).

@nohwnd
Copy link
Member Author

nohwnd commented Nov 12, 2024

We are still missing the help option (OnHelpRequested callback).

agree, I fixed the discovery and artifacts here. Will leave the help for next PR, because it looks weirdly broken.

nohwnd
nohwnd commented Dec 4, 2024
View reviewed changes
eng/Version.Details.xml Outdated Show resolved Hide resolved
@build-analysis build-analysis bot mentioned this pull request Dec 10, 2024
Open
3 tasks
@build-analysis build-analysis bot mentioned this pull request Dec 11, 2024
Open
nohwnd
nohwnd commented Dec 12, 2024
View reviewed changes
eng/Versions.props Outdated Show resolved Hide resolved
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mariam-abdulla mariam-abdulla mariam-abdulla approved these changes

@Evangelink Evangelink Evangelink left review comments

Assignees
No one assigned
Labels
Area-DotNet Test untriaged Request triage from a team member
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@nohwnd @ViktorHofer @mariam-abdulla @Evangelink