Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix failure building .NET Standard 2.1 projects #3463

Merged
merged 1 commit into from
Jul 26, 2019
Merged

Fix failure building .NET Standard 2.1 projects #3463

merged 1 commit into from
Jul 26, 2019

Conversation

dsplaisted
Copy link
Member

Since the .NET Standard 2.1 targeting pack added PackageOverrides.txt, building .NET Standard 2.1 projects is broken. The problem is that ResolveTargetingPackAssets was using the RuntimeFrameworkName metadata from the targeting pack as the itemspec for PackageConflictOverrides. This metadata wasn't set for the .NET Standard 2.1 targeting pack, causing the following error:

C:\git\dotnet-sdk\artifacts\bin\Debug\Sdks\Microsoft.NET.Sdk\targets\Microsoft.NET.Sdk.FrameworkReferenceResolution.targets(269,7): error MSB4028: The "ResolveTargetingPackAssets" task's outputs could not be retrieved from the "PackageConflictOverrides" parameter. Parameter "includeEscaped" cannot have zero length. [C:\git\dotnet-sdk\artifacts\tmp\Debug\netstandard\netstandard.csproj]

@dsplaisted dsplaisted requested a review from a team July 26, 2019 02:02
dougbu added a commit to dotnet/efcore that referenced this pull request Jul 26, 2019
@dougbu
Add workaround for netstandard2.1 problem in preview7 SDK
a2de2e8 
- see dotnet/sdk#3463
dotnet-maestro bot added a commit to dotnet/efcore that referenced this pull request Jul 26, 2019
@dotnet-maestro
[master] Update dependencies from aspnet/Extensions (#16757)
ef511c7 
* Update dependencies from https://github.com/aspnet/Extensions build 20190725.4

- Microsoft.Extensions.Configuration.Json - 3.0.0-preview8.19375.4
- Microsoft.Extensions.DependencyInjection - 3.0.0-preview8.19375.4
- Microsoft.Extensions.Configuration.EnvironmentVariables - 3.0.0-preview8.19375.4
- Microsoft.Extensions.Configuration - 3.0.0-preview8.19375.4
- Microsoft.Extensions.Caching.Memory - 3.0.0-preview8.19375.4
- Microsoft.Extensions.HostFactoryResolver.Sources - 3.0.0-preview8.19375.4
- Microsoft.Extensions.Logging - 3.0.0-preview8.19375.4

Dependency coherency updates

- Microsoft.NETCore.App.Runtime.win-x64 - 3.0.0-preview8-28374-06 (parent: Microsoft.Extensions.Logging)
- Microsoft.DotNet.PlatformAbstractions - 3.0.0-preview8-28374-06 (parent: Microsoft.Extensions.Logging)
- Microsoft.Extensions.DependencyModel - 3.0.0-preview8-28374-06 (parent: Microsoft.Extensions.Logging)
- Microsoft.NETCore.App.Ref - 3.0.0-preview8-28374-06 (parent: Microsoft.Extensions.Logging)
- NETStandard.Library.Ref - 2.1.0-preview8-28374-06 (parent: Microsoft.Extensions.Logging)

* Update dependencies from https://github.com/aspnet/Extensions build 20190725.5

- Microsoft.Extensions.Configuration.Json - 3.0.0-preview8.19375.5
- Microsoft.Extensions.DependencyInjection - 3.0.0-preview8.19375.5
- Microsoft.Extensions.Configuration.EnvironmentVariables - 3.0.0-preview8.19375.5
- Microsoft.Extensions.Configuration - 3.0.0-preview8.19375.5
- Microsoft.Extensions.Caching.Memory - 3.0.0-preview8.19375.5
- Microsoft.Extensions.HostFactoryResolver.Sources - 3.0.0-preview8.19375.5
- Microsoft.Extensions.Logging - 3.0.0-preview8.19375.5

Dependency coherency updates

- Microsoft.CSharp - 4.6.0-preview8.19375.8 (parent: Microsoft.NETCore.App.Runtime.win-x64)
- Microsoft.NETCore.App.Runtime.win-x64 - 3.0.0-preview8-28375-11 (parent: Microsoft.Extensions.Logging)
- Microsoft.DotNet.PlatformAbstractions - 3.0.0-preview8-28375-11 (parent: Microsoft.Extensions.Logging)
- Microsoft.Extensions.DependencyModel - 3.0.0-preview8-28375-11 (parent: Microsoft.Extensions.Logging)
- Microsoft.NETCore.Platforms - 3.0.0-preview8.19375.8 (parent: Microsoft.NETCore.App.Runtime.win-x64)
- Microsoft.NETCore.App.Ref - 3.0.0-preview8-28375-11 (parent: Microsoft.Extensions.Logging)
- NETStandard.Library.Ref - 2.1.0-preview8-28375-11 (parent: Microsoft.Extensions.Logging)
- System.Collections.Immutable - 1.6.0-preview8.19375.8 (parent: Microsoft.NETCore.App.Runtime.win-x64)
- System.ComponentModel.Annotations - 4.6.0-preview8.19375.8 (parent: Microsoft.NETCore.App.Runtime.win-x64)
- System.Diagnostics.DiagnosticSource - 4.6.0-preview8.19375.8 (parent: Microsoft.NETCore.App.Runtime.win-x64)

* Add workaround for netstandard2.1 problem in preview7 SDK
- see dotnet/sdk#3463
@dsplaisted dsplaisted merged commit c2628eb into dotnet:master Jul 26, 2019
dougbu added a commit to dotnet/aspnetcore that referenced this pull request Jul 26, 2019
@dougbu
Add workaround for netstandard2.1 problem in preview7 SDK / CLI
2bdd39f 
- see dotnet/sdk#3463
@dougbu dougbu mentioned this pull request Jul 30, 2019
Merged
dougbu added a commit to dotnet/aspnetcore that referenced this pull request Jul 30, 2019
@dougbu
Add .NET Standard 2.1 workaround
905c8dc 
- we don't have dotnet/sdk#3463 fix
dougbu added a commit to dotnet/aspnetcore that referenced this pull request Jul 30, 2019
@dougbu
Add .NET Standard 2.1 workaround
6a2b1e0 
- we don't have dotnet/sdk#3463 fix
wtgodbe pushed a commit to dotnet/aspnetcore that referenced this pull request Jul 30, 2019
@dougbu @wtgodbe
Add .NET Standard 2.1 workaround
a453cb2 
- we don't have dotnet/sdk#3463 fix
dougbu pushed a commit to dotnet/aspnetcore that referenced this pull request Aug 1, 2019
@dotnet-maestro @dougbu
[release/3.0] Update dependencies from 3 repositories (#12699)
97489dc 
Update dependencies from https://github.com/aspnet/Blazor build 20190729.2
- Microsoft.AspNetCore.Blazor.Mono - 3.0.0-preview9.19379.2

Add .NET Standard 2.1 workaround (@dougbu)
 - we don't have dotnet/sdk#3463 fix

* Update dependencies from https://github.com/aspnet/AspNetCore-Tooling build 20190731.10
- Microsoft.NET.Sdk.Razor - 5.0.0-alpha1.19381.10
- Microsoft.CodeAnalysis.Razor - 5.0.0-alpha1.19381.10
- Microsoft.AspNetCore.Razor.Language - 5.0.0-alpha1.19381.10
- Microsoft.AspNetCore.Mvc.Razor.Extensions - 5.0.0-alpha1.19381.10

Dependency coherency updates
- Microsoft.Net.Compilers.Toolset - 3.3.0-beta2-19374-05 (parent: Microsoft.Extensions.Logging)

* Update dependencies from https://github.com/aspnet/EntityFrameworkCore build 20190731.15
- Microsoft.EntityFrameworkCore.Tools - 3.0.0-preview9.19381.15
- Microsoft.EntityFrameworkCore.SqlServer - 3.0.0-preview9.19381.15
- dotnet-ef - 3.0.0-preview9.19381.15
- Microsoft.EntityFrameworkCore - 3.0.0-preview9.19381.15
- Microsoft.EntityFrameworkCore.InMemory - 3.0.0-preview9.19381.15
- Microsoft.EntityFrameworkCore.Relational - 3.0.0-preview9.19381.15
- Microsoft.EntityFrameworkCore.Sqlite - 3.0.0-preview9.19381.15

Dependency coherency updates
- Microsoft.AspNetCore.Analyzer.Testing - 3.0.0-preview9.19381.9 (parent: Microsoft.EntityFrameworkCore)
- Microsoft.AspNetCore.BenchmarkRunner.Sources - 3.0.0-preview9.19381.9 (parent: Microsoft.EntityFrameworkCore)
- Microsoft.Extensions.ActivatorUtilities.Sources - 3.0.0-preview9.19381.9 (parent: Microsoft.EntityFrameworkCore)
- Microsoft.Extensions.Caching.Abstractions - 3.0.0-preview9.19381.9 (parent: Microsoft.EntityFrameworkCore)
- Microsoft.Extensions.Caching.Memory - 3.0.0-preview9.19381.9 (parent: Microsoft.EntityFrameworkCore)
- Microsoft.Extensions.Caching.SqlServer - 3.0.0-preview9.19381.9 (parent: Microsoft.EntityFrameworkCore)
- Microsoft.Extensions.Caching.StackExchangeRedis - 3.0.0-preview9.19381.9 (parent: Microsoft.EntityFrameworkCore)
- Microsoft.Extensions.CommandLineUtils.Sources - 3.0.0-preview9.19381.9 (parent: Microsoft.EntityFrameworkCore)
- Microsoft.Extensions.Configuration.Abstractions - 3.0.0-preview9.19381.9 (parent: Microsoft.EntityFrameworkCore)
- Microsoft.Extensions.Configuration.AzureKeyVault - 3.0.0-preview9.19381.9 (parent: Microsoft.EntityFrameworkCore)
- Microsoft.Extensions.Configuration.Binder - 3.0.0-preview9.19381.9 (parent: Microsoft.EntityFrameworkCore)
- Microsoft.Extensions.Configuration.CommandLine - 3.0.0-preview9.19381.9 (parent: Microsoft.EntityFrameworkCore)
- Microsoft.Extensions.Configuration.EnvironmentVariables - 3.0.0-preview9.19381.9 (parent: Microsoft.EntityFrameworkCore)
- Microsoft.Extensions.Configuration.FileExtensions - 3.0.0-preview9.19381.9 (parent: Microsoft.EntityFrameworkCore)
- Microsoft.Extensions.Configuration.Ini - 3.0.0-preview9.19381.9 (parent: Microsoft.EntityFrameworkCore)
- Microsoft.Extensions.Configuration.Json - 3.0.0-preview9.19381.9 (parent: Microsoft.EntityFrameworkCore)
- Microsoft.Extensions.Configuration.KeyPerFile - 3.0.0-preview9.19381.9 (parent: Microsoft.EntityFrameworkCore)
- Microsoft.Extensions.Configuration.UserSecrets - 3.0.0-preview9.19381.9 (parent: Microsoft.EntityFrameworkCore)
- Microsoft.Extensions.Configuration.Xml - 3.0.0-preview9.19381.9 (parent: Microsoft.EntityFrameworkCore)
- Microsoft.Extensions.Configuration - 3.0.0-preview9.19381.9 (parent: Microsoft.EntityFrameworkCore)
- Microsoft.Extensions.DependencyInjection.Abstractions - 3.0.0-preview9.19381.9 (parent: Microsoft.EntityFrameworkCore)
- Microsoft.Extensions.DependencyInjection - 3.0.0-preview9.19381.9 (parent: Microsoft.EntityFrameworkCore)
- Microsoft.Extensions.DiagnosticAdapter - 3.0.0-preview9.19381.9 (parent: Microsoft.EntityFrameworkCore)
- Microsoft.Extensions.Diagnostics.HealthChecks.Abstractions - 3.0.0-preview9.19381.9 (parent: Microsoft.EntityFrameworkCore)
- Microsoft.Extensions.Diagnostics.HealthChecks - 3.0.0-preview9.19381.9 (parent: Microsoft.EntityFrameworkCore)
- Microsoft.Extensions.FileProviders.Abstractions - 3.0.0-preview9.19381.9 (parent: Microsoft.EntityFrameworkCore)
- Microsoft.Extensions.FileProviders.Composite - 3.0.0-preview9.19381.9 (parent: Microsoft.EntityFrameworkCore)
- Microsoft.Extensions.FileProviders.Embedded - 3.0.0-preview9.19381.9 (parent: Microsoft.EntityFrameworkCore)
- Microsoft.Extensions.FileProviders.Physical - 3.0.0-preview9.19381.9 (parent: Microsoft.EntityFrameworkCore)
- Microsoft.Extensions.FileSystemGlobbing - 3.0.0-preview9.19381.9 (parent: Microsoft.EntityFrameworkCore)
- Microsoft.Extensions.HashCodeCombiner.Sources - 3.0.0-preview9.19381.9 (parent: Microsoft.EntityFrameworkCore)
- Microsoft.Extensions.Hosting.Abstractions - 3.0.0-preview9.19381.9 (parent: Microsoft.EntityFrameworkCore)
- Microsoft.Extensions.Hosting - 3.0.0-preview9.19381.9 (parent: Microsoft.EntityFrameworkCore)
- Microsoft.Extensions.HostFactoryResolver.Sources - 3.0.0-preview9.19381.9 (parent: Microsoft.EntityFrameworkCore)
- Microsoft.Extensions.Http - 3.0.0-preview9.19381.9 (parent: Microsoft.EntityFrameworkCore)
- Microsoft.Extensions.Localization.Abstractions - 3.0.0-preview9.19381.9 (parent: Microsoft.EntityFrameworkCore)
- Microsoft.Extensions.Localization - 3.0.0-preview9.19381.9 (parent: Microsoft.EntityFrameworkCore)
- Microsoft.Extensions.Logging.Abstractions - 3.0.0-preview9.19381.9 (parent: Microsoft.EntityFrameworkCore)
- Microsoft.Extensions.Logging.AzureAppServices - 3.0.0-preview9.19381.9 (parent: Microsoft.EntityFrameworkCore)
- Microsoft.Extensions.Logging.Configuration - 3.0.0-preview9.19381.9 (parent: Microsoft.EntityFrameworkCore)
- Microsoft.Extensions.Logging.Console - 3.0.0-preview9.19381.9 (parent: Microsoft.EntityFrameworkCore)
- Microsoft.Extensions.Logging.Debug - 3.0.0-preview9.19381.9 (parent: Microsoft.EntityFrameworkCore)
- Microsoft.Extensions.Logging.EventSource - 3.0.0-preview9.19381.9 (parent: Microsoft.EntityFrameworkCore)
- Microsoft.Extensions.Logging.EventLog - 3.0.0-preview9.19381.9 (parent: Microsoft.EntityFrameworkCore)
- Microsoft.Extensions.Logging.TraceSource - 3.0.0-preview9.19381.9 (parent: Microsoft.EntityFrameworkCore)
- Microsoft.Extensions.Logging.Testing - 3.0.0-preview9.19381.9 (parent: Microsoft.EntityFrameworkCore)
- Microsoft.Extensions.ObjectPool - 3.0.0-preview9.19381.9 (parent: Microsoft.EntityFrameworkCore)
- Microsoft.Extensions.Options.ConfigurationExtensions - 3.0.0-preview9.19381.9 (parent: Microsoft.EntityFrameworkCore)
- Microsoft.Extensions.Options.DataAnnotations - 3.0.0-preview9.19381.9 (parent: Microsoft.EntityFrameworkCore)
- Microsoft.Extensions.Options - 3.0.0-preview9.19381.9 (parent: Microsoft.EntityFrameworkCore)
- Microsoft.Extensions.ParameterDefaultValue.Sources - 3.0.0-preview9.19381.9 (parent: Microsoft.EntityFrameworkCore)
- Microsoft.Extensions.Primitives - 3.0.0-preview9.19381.9 (parent: Microsoft.EntityFrameworkCore)
- Microsoft.Extensions.TypeNameHelper.Sources - 3.0.0-preview9.19381.9 (parent: Microsoft.EntityFrameworkCore)
- Microsoft.Extensions.ValueStopwatch.Sources - 3.0.0-preview9.19381.9 (parent: Microsoft.EntityFrameworkCore)
- Microsoft.Extensions.WebEncoders - 3.0.0-preview9.19381.9 (parent: Microsoft.EntityFrameworkCore)
- Microsoft.Internal.Extensions.Refs - 3.0.0-preview9.19381.9 (parent: Microsoft.EntityFrameworkCore)
- Microsoft.JSInterop - 3.0.0-preview9.19381.9 (parent: Microsoft.EntityFrameworkCore)
- Mono.WebAssembly.Interop - 3.0.0-preview9.19381.9 (parent: Microsoft.EntityFrameworkCore)
- Microsoft.Bcl.AsyncInterfaces - 1.0.0-preview8.19378.8 (parent: Microsoft.NETCore.App.Runtime.win-x64)
- Microsoft.NETCore.App.Runtime.win-x64 - 3.0.0-preview8-28379-05 (parent: Microsoft.Extensions.Logging)
- Microsoft.Extensions.Logging - 3.0.0-preview9.19381.9 (parent: Microsoft.EntityFrameworkCore)
- Microsoft.CSharp - 4.6.0-preview8.19378.8 (parent: Microsoft.NETCore.App.Runtime.win-x64)
- Microsoft.Win32.Registry - 4.6.0-preview8.19378.8 (parent: Microsoft.NETCore.App.Runtime.win-x64)
- Microsoft.Win32.SystemEvents - 4.6.0-preview8.19378.8 (parent: Microsoft.NETCore.App.Runtime.win-x64)
- System.ComponentModel.Annotations - 4.6.0-preview8.19378.8 (parent: Microsoft.NETCore.App.Runtime.win-x64)
- System.Diagnostics.EventLog - 4.6.0-preview8.19378.8 (parent: Microsoft.NETCore.App.Runtime.win-x64)
- System.Drawing.Common - 4.6.0-preview8.19378.8 (parent: Microsoft.NETCore.App.Runtime.win-x64)
- System.IO.Pipelines - 4.6.0-preview8.19378.8 (parent: Microsoft.NETCore.App.Runtime.win-x64)
- System.Net.Http.WinHttpHandler - 4.6.0-preview8.19378.8 (parent: Microsoft.NETCore.App.Runtime.win-x64)
- System.Net.WebSockets.WebSocketProtocol - 4.6.0-preview8.19378.8 (parent: Microsoft.NETCore.App.Runtime.win-x64)
- System.Reflection.Metadata - 1.7.0-preview8.19378.8 (parent: Microsoft.NETCore.App.Runtime.win-x64)
- System.Runtime.CompilerServices.Unsafe - 4.6.0-preview8.19378.8 (parent: Microsoft.NETCore.App.Runtime.win-x64)
- System.Security.Cryptography.Cng - 4.6.0-preview8.19378.8 (parent: Microsoft.NETCore.App.Runtime.win-x64)
- System.Security.Cryptography.Pkcs - 4.6.0-preview8.19378.8 (parent: Microsoft.NETCore.App.Runtime.win-x64)
- System.Security.Cryptography.Xml - 4.6.0-preview8.19378.8 (parent: Microsoft.NETCore.App.Runtime.win-x64)
- System.Security.Permissions - 4.6.0-preview8.19378.8 (parent: Microsoft.NETCore.App.Runtime.win-x64)
- System.Security.Principal.Windows - 4.6.0-preview8.19378.8 (parent: Microsoft.NETCore.App.Runtime.win-x64)
- System.ServiceProcess.ServiceController - 4.6.0-preview8.19378.8 (parent: Microsoft.NETCore.App.Runtime.win-x64)
- System.Text.Encodings.Web - 4.6.0-preview8.19378.8 (parent: Microsoft.NETCore.App.Runtime.win-x64)
- System.Text.Json - 4.6.0-preview8.19378.8 (parent: Microsoft.NETCore.App.Runtime.win-x64)
- System.Threading.Channels - 4.6.0-preview8.19378.8 (parent: Microsoft.NETCore.App.Runtime.win-x64)
- System.Windows.Extensions - 4.6.0-preview8.19378.8 (parent: Microsoft.NETCore.App.Runtime.win-x64)
- Microsoft.Extensions.DependencyModel - 3.0.0-preview8-28379-05 (parent: Microsoft.Extensions.Logging)
- Microsoft.NETCore.App.Ref - 3.0.0-preview8-28379-05 (parent: Microsoft.Extensions.Logging)
- NETStandard.Library.Ref - 2.1.0-preview8-28379-05 (parent: Microsoft.Extensions.Logging)
- Microsoft.NETCore.Platforms - 3.0.0-preview8.19378.8 (parent: Microsoft.NETCore.App.Runtime.win-x64)
- Internal.AspNetCore.Analyzers - 3.0.0-preview9.19381.9 (parent: Microsoft.EntityFrameworkCore)
- Microsoft.AspNetCore.Testing - 3.0.0-preview9.19381.9 (parent: Microsoft.EntityFrameworkCore)
- Microsoft.Net.Compilers.Toolset - 3.3.0-beta2-19381-04 (parent: Microsoft.Extensions.Logging)
dsplaisted pushed a commit to dsplaisted/sdk that referenced this pull request Feb 19, 2020
@dotnet-maestro
Update dependencies from https://github.com/aspnet/websdk build 20191…
ebf7a76 
…104.3 (dotnet#3463)

- Microsoft.NET.Sdk.Web - 3.1.100-preview3.19554.3
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@peterhuene peterhuene peterhuene approved these changes

@nguerrera nguerrera nguerrera approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@dsplaisted @nguerrera @peterhuene