[main] Update dependencies from dotnet/runtime #33841

dotnet-maestro · 2023-07-07T04:20:41Z

This pull request updates the following dependencies

From https://github.com/dotnet/runtime

Subscription: aa69f164-2492-460a-3914-08d8e9750bf8
Build: 20230707.3
Date Produced: July 7, 2023 3:07:23 PM UTC
Commit: 24d7f5a58ac4bcee1ec5197427068e437f19552f
Branch: refs/heads/main

Updates:
- Microsoft.Extensions.DependencyModel: from 8.0.0-preview.7.23356.10 to 8.0.0-preview.7.23357.3
- Microsoft.Extensions.FileSystemGlobbing: from 8.0.0-preview.7.23356.10 to 8.0.0-preview.7.23357.3
- Microsoft.Extensions.Logging.Console: from 8.0.0-preview.7.23356.10 to 8.0.0-preview.7.23357.3
- Microsoft.NET.HostModel: from 8.0.0-preview.7.23356.10 to 8.0.0-preview.7.23357.3
- Microsoft.NET.ILLink.Tasks: from 8.0.0-preview.7.23356.10 to 8.0.0-preview.7.23357.3
- Microsoft.NETCore.App.Host.win-x64: from 8.0.0-preview.7.23356.10 to 8.0.0-preview.7.23357.3
- Microsoft.NETCore.App.Ref: from 8.0.0-preview.7.23356.10 to 8.0.0-preview.7.23357.3
- Microsoft.NETCore.App.Runtime.win-x64: from 8.0.0-preview.7.23356.10 to 8.0.0-preview.7.23357.3
- Microsoft.NETCore.DotNetHostResolver: from 8.0.0-preview.7.23356.10 to 8.0.0-preview.7.23357.3
- Microsoft.NETCore.Platforms: from 8.0.0-preview.7.23356.10 to 8.0.0-preview.7.23357.3
- System.CodeDom: from 8.0.0-preview.7.23356.10 to 8.0.0-preview.7.23357.3
- System.Reflection.MetadataLoadContext: from 8.0.0-preview.7.23356.10 to 8.0.0-preview.7.23357.3
- System.Resources.Extensions: from 8.0.0-preview.7.23356.10 to 8.0.0-preview.7.23357.3
- System.Security.Cryptography.ProtectedData: from 8.0.0-preview.7.23356.10 to 8.0.0-preview.7.23357.3
- System.ServiceProcess.ServiceController: from 8.0.0-preview.7.23356.10 to 8.0.0-preview.7.23357.3
- System.Text.Encoding.CodePages: from 8.0.0-preview.7.23356.10 to 8.0.0-preview.7.23357.3
- VS.Redist.Common.NetCore.SharedFramework.x64.8.0: from 8.0.0-preview.7.23356.10 to 8.0.0-preview.7.23357.3
- VS.Redist.Common.NetCore.TargetingPack.x64.8.0: from 8.0.0-preview.7.23356.10 to 8.0.0-preview.7.23357.3

…0706.15 Microsoft.Extensions.DependencyModel , Microsoft.Extensions.FileSystemGlobbing , Microsoft.Extensions.Logging.Console , Microsoft.NET.HostModel , Microsoft.NET.ILLink.Tasks , Microsoft.NETCore.App.Host.win-x64 , Microsoft.NETCore.App.Ref , Microsoft.NETCore.App.Runtime.win-x64 , Microsoft.NETCore.DotNetHostResolver , Microsoft.NETCore.Platforms , System.CodeDom , System.Reflection.MetadataLoadContext , System.Resources.Extensions , System.Security.Cryptography.ProtectedData , System.ServiceProcess.ServiceController , System.Text.Encoding.CodePages , VS.Redist.Common.NetCore.SharedFramework.x64.8.0 , VS.Redist.Common.NetCore.TargetingPack.x64.8.0 From Version 8.0.0-preview.7.23356.10 -> To Version 8.0.0-preview.7.23356.15

dotnet-maestro · 2023-07-07T05:11:16Z

Notification for subscribed users from https://github.com/dotnet/runtime:

@dotnet/dnr-codeflow

Action requested: Please take a look at this failing automated dependency-flow pull request's checks; failures may be related to changes which originated in your repo.

This pull request contains changes from your source repo (https://github.com/dotnet/runtime) and seems to have failed checks in this PR. Please take a peek at the failures and comment if they seem relevant to your changes.
If you're being tagged in this comment it is due to an entry in the related Maestro Subscription of the Build Asset Registry. If you feel this entry has added your GitHub login or your GitHub team in error, please update the subscription to reflect this.
For more details, please read the Arcade Darc documentation

v-wuzhai · 2023-07-07T07:11:07Z

@dotnet/runtime-infrastructure @radical the flow from runtime is blocked due to a bunch of failed tests, could you take a look.

radical · 2023-07-07T07:18:03Z

The failures seem to be of the form:

Microsoft.DotNet.GenAPI.Tests.CSharpFileBuilderTests.TestAttributeWithInternalTypeArgumentOmitted(includeInternalSymbols: True) [FAIL]

Expected:

namespace A
{
    public partial class AnyTestAttribute : System.Attribute
    {
        public AnyTestAttribute(System.Type xType) { }

        public System.Type XType { get { throw null; } set { } }
    }

    internal partial class InternalClass
    {
    }

    [AnyTest(typeof(InternalClass))]
    [System.Obsolete]
    public partial class PublicClass
    {
    }
}

Resulted:

namespace A
{
    [System.Runtime.CompilerServices.NullableContext(1)]
    [System.Runtime.CompilerServices.Nullable(0)]
    public partial class AnyTestAttribute : System.Attribute
    {
        public AnyTestAttribute(System.Type xType) { }

        public System.Type XType { get { throw null; } set { } }
    }

    internal partial class InternalClass
    {
    }

    [AnyTest(typeof(InternalClass))]
    [System.Obsolete]
    public partial class PublicClass
    {
    }
}

The difference being these new attributes:

   [System.Runtime.CompilerServices.NullableContext(1)]
   [System.Runtime.CompilerServices.Nullable(0)]

.. which is probably because of dotnet/runtime#87857 . cc @stephentoub

Are these files expected to be updated manually to have the attributes?

…0706.16 Microsoft.Extensions.DependencyModel , Microsoft.Extensions.FileSystemGlobbing , Microsoft.Extensions.Logging.Console , Microsoft.NET.HostModel , Microsoft.NET.ILLink.Tasks , Microsoft.NETCore.App.Host.win-x64 , Microsoft.NETCore.App.Ref , Microsoft.NETCore.App.Runtime.win-x64 , Microsoft.NETCore.DotNetHostResolver , Microsoft.NETCore.Platforms , System.CodeDom , System.Reflection.MetadataLoadContext , System.Resources.Extensions , System.Security.Cryptography.ProtectedData , System.ServiceProcess.ServiceController , System.Text.Encoding.CodePages , VS.Redist.Common.NetCore.SharedFramework.x64.8.0 , VS.Redist.Common.NetCore.TargetingPack.x64.8.0 From Version 8.0.0-preview.7.23356.10 -> To Version 8.0.0-preview.7.23356.16

.. attributes. Prompted by dotnet/runtime#87857 .

radical · 2023-07-07T07:49:56Z

I have pushed a change for this d14fd69 . Could somebody validate it?

…0707.2 Microsoft.Extensions.DependencyModel , Microsoft.Extensions.FileSystemGlobbing , Microsoft.Extensions.Logging.Console , Microsoft.NET.HostModel , Microsoft.NET.ILLink.Tasks , Microsoft.NETCore.App.Host.win-x64 , Microsoft.NETCore.App.Ref , Microsoft.NETCore.App.Runtime.win-x64 , Microsoft.NETCore.DotNetHostResolver , Microsoft.NETCore.Platforms , System.CodeDom , System.Reflection.MetadataLoadContext , System.Resources.Extensions , System.Security.Cryptography.ProtectedData , System.ServiceProcess.ServiceController , System.Text.Encoding.CodePages , VS.Redist.Common.NetCore.SharedFramework.x64.8.0 , VS.Redist.Common.NetCore.TargetingPack.x64.8.0 From Version 8.0.0-preview.7.23356.10 -> To Version 8.0.0-preview.7.23357.2

jeffschwMSFT · 2023-07-07T14:23:25Z

looks like a ephemeral error:

�[m�[37m        StdErr:
�[m�[37m        Error: No such container: d164cbd12894722c0192fc230053c3f7541e053f150d1b247b2b1681323a17b1
�[m�[37m        Exit Code: 1

…0707.3 Microsoft.Extensions.DependencyModel , Microsoft.Extensions.FileSystemGlobbing , Microsoft.Extensions.Logging.Console , Microsoft.NET.HostModel , Microsoft.NET.ILLink.Tasks , Microsoft.NETCore.App.Host.win-x64 , Microsoft.NETCore.App.Ref , Microsoft.NETCore.App.Runtime.win-x64 , Microsoft.NETCore.DotNetHostResolver , Microsoft.NETCore.Platforms , System.CodeDom , System.Reflection.MetadataLoadContext , System.Resources.Extensions , System.Security.Cryptography.ProtectedData , System.ServiceProcess.ServiceController , System.Text.Encoding.CodePages , VS.Redist.Common.NetCore.SharedFramework.x64.8.0 , VS.Redist.Common.NetCore.TargetingPack.x64.8.0 From Version 8.0.0-preview.7.23356.10 -> To Version 8.0.0-preview.7.23357.3

ericstj · 2023-07-07T16:24:26Z

@jeffschwMSFT. Here's more of the surrounding context:

�[m�[37m        > docker run --rm --name test-container-1 --publish 5017:8080 --detach localhost:5010/endtoend_noapi_web:1.0
�[m�[37m        e52dc6a8fe8ed138f6a36c890d57b2a108ad5bcfa166e55fe2dbc6736c058247
�[m�[37m        > docker logs e52dc6a8fe8ed138f6a36c890d57b2a108ad5bcfa166e55fe2dbc6736c058247
�[m�[37m        
�[m�[37m        
�[m�[37m        StdErr:
�[m�[37m        Error: No such container: e52dc6a8fe8ed138f6a36c890d57b2a108ad5bcfa166e55fe2dbc6736c058247

So this is starting up a container and letting it run in the background, with the flag to delete the container when it exits. Normally it looks like this is expected to run indefinitely until the docker stop command is sent.

sdk/src/Tests/Microsoft.NET.Build.Containers.IntegrationTests/EndToEndTests.cs

Lines 263 to 311 in f8336e3

    
           CommandResult processResult = ContainerCli.RunCommand( 
        
               _testOutput, 
        
               "--rm", 
        
               "--name", 
        
               containerName, 
        
               "--publish", 
        
               "5017:8080", 
        
               "--detach", 
        
               $"{DockerRegistryManager.LocalRegistry}/{imageName}:{imageTag}") 
        
           .Execute(); 
        
           processResult.Should().Pass(); 
        
           Assert.NotNull(processResult.StdOut); 
        
           string appContainerId = processResult.StdOut.Trim(); 
        
           bool everSucceeded = false; 
        
           HttpClient client = new(); 
        
           // Give the server a moment to catch up, but no more than necessary. 
        
           for (int retry = 0; retry < 10; retry++) 
        
           { 
        
               try 
        
               { 
        
                   var response = await client.GetAsync("http://localhost:5017/weatherforecast").ConfigureAwait(false); 
        
                   if (response.IsSuccessStatusCode) 
        
                   { 
        
                       everSucceeded = true; 
        
                       break; 
        
                   } 
        
               } 
        
               catch { } 
        
               await Task.Delay(TimeSpan.FromSeconds(1)).ConfigureAwait(false); 
        
           } 
        
           ContainerCli.LogsCommand(_testOutput, appContainerId) 
        
               .Execute() 
        
               .Should().Pass(); 
        
           Assert.True(everSucceeded, "http://localhost:5017/weatherforecast never responded."); 
        
           ContainerCli.StopCommand(_testOutput, appContainerId) 
        
               .Execute() 
        
               .Should().Pass(); 
        
           newProjectDir.Delete(true); 
        
           privateNuGetAssets.Delete(true);

Looks to me like the test could be failing due to the container failing to start up and then being deleted. Let's see if it repros in the new build, or if we need to dig into why the container is exiting early. cc @baronfel @tmds @vlada-shubina

baronfel · 2023-07-07T16:28:11Z

@ericstj your analysis is spot on. We've got a known issue logged in the tracking issue for these failures, and we hope to have a team member dig into what's happening there. For now a restart usually clears it up, and it should only ever impact the Ubuntu leg. In the future you can tag @dotnet/sdk-container-builds-maintainers to raise a flag if required.

ericstj

This is good to unblock codeflow. I filed #33853 to fix GenAPI. It shouldn't emit those attributes.

jeffschwMSFT · 2023-07-07T16:59:55Z

Same docker failure, rerunning leg. If it fails again we can merge on red with the known issue

ericstj · 2023-07-07T18:20:53Z

I wonder if the exact same symptom might happen if the test app in the container crashed? Wouldn't that cause the container to exit and be cleaned up? Might be a good idea to remove that -rm switch and do docker rm as a final operation - fetching the logs from the container before it's deleted.

I agree with @jeffschwMSFT though -- if this is the only thing failing it's unlikely to be a significant problem with the runtime. It does seem like this is reproducing more than just occasionally though so we might need to disable that test.

jeffschwMSFT

lgtm

jeffschwMSFT · 2023-07-07T19:01:53Z

@dotnet/domestic-cat I do not have admin permissions in sdk. can we get assistance with this merge with known issues?

dotnet-issue-labeler bot added Area-CodeFlow untriaged Request triage from a team member labels Jul 7, 2023

dotnet-maestro bot and others added 2 commits July 7, 2023 07:42

Update CSharpFileBuilderTests to include the NullableContext

d14fd69

.. attributes. Prompted by dotnet/runtime#87857 .

fix tests based on the actual generated output from the tests

11377fb

radical requested review from ericstj and lewing July 7, 2023 08:45

ericstj mentioned this pull request Jul 7, 2023

GenAPI emits nullable attributes #33853

Closed

ericstj approved these changes Jul 7, 2023

View reviewed changes

lewing mentioned this pull request Jul 7, 2023

[main] Update dependencies from dotnet/aspnetcore #33854

Merged

jeffschwMSFT approved these changes Jul 7, 2023

View reviewed changes

Disable failing test

4e265dc

marcpopMSFT requested a review from a team as a code owner July 7, 2023 19:29

marcpopMSFT merged commit 511c2c8 into main Jul 7, 2023

marcpopMSFT deleted the darc-main-17e35b17-c3cc-422d-aa27-03bc9d037dff branch July 7, 2023 19:29

radical mentioned this pull request Jul 7, 2023

[wasm] Perf pipeline completely broken dotnet/runtime#88534

Closed

build-analysis bot mentioned this pull request Jul 7, 2023

Checkout failure: "Git fetch failed with exit code 128" dotnet/arcade#9009

Open

2 tasks

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[main] Update dependencies from dotnet/runtime #33841

[main] Update dependencies from dotnet/runtime #33841

dotnet-maestro bot commented Jul 7, 2023 •

edited

Loading

dotnet-maestro bot commented Jul 7, 2023

v-wuzhai commented Jul 7, 2023

radical commented Jul 7, 2023

radical commented Jul 7, 2023

jeffschwMSFT commented Jul 7, 2023

ericstj commented Jul 7, 2023

baronfel commented Jul 7, 2023

ericstj left a comment

jeffschwMSFT commented Jul 7, 2023

ericstj commented Jul 7, 2023 •

edited

Loading

jeffschwMSFT left a comment

jeffschwMSFT commented Jul 7, 2023

[main] Update dependencies from dotnet/runtime #33841

[main] Update dependencies from dotnet/runtime #33841

Conversation

dotnet-maestro bot commented Jul 7, 2023 • edited Loading

From https://github.com/dotnet/runtime

dotnet-maestro bot commented Jul 7, 2023

Notification for subscribed users from https://github.com/dotnet/runtime:

Action requested: Please take a look at this failing automated dependency-flow pull request's checks; failures may be related to changes which originated in your repo.

v-wuzhai commented Jul 7, 2023

radical commented Jul 7, 2023

Expected:

Resulted:

radical commented Jul 7, 2023

jeffschwMSFT commented Jul 7, 2023

ericstj commented Jul 7, 2023

baronfel commented Jul 7, 2023

ericstj left a comment

Choose a reason for hiding this comment

jeffschwMSFT commented Jul 7, 2023

ericstj commented Jul 7, 2023 • edited Loading

jeffschwMSFT left a comment

Choose a reason for hiding this comment

jeffschwMSFT commented Jul 7, 2023

dotnet-maestro bot commented Jul 7, 2023 •

edited

Loading

ericstj commented Jul 7, 2023 •

edited

Loading