Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support PublishReadyToRun for framework-dependent deployment #3326

Merged
merged 4 commits into from
Jun 18, 2019

Conversation

nguerrera
Copy link
Contributor

@nguerrera nguerrera commented Jun 12, 2019

Fix #3110

@nguerrera
Copy link
Contributor Author

cc @dsplaisted @fadimounir @peterhuene

This is still a draft, but I'm interested in feedback on the approach. It feels a little clunky that you now cannot assume invariant of RuntimePackAsset non-empty == self-contained, and that I had to run a separate conflict resolution pass in the crossgen + fdd. So I'm interested in other ideas. I don't think this is terrible, though, so if you think this isn't too bad, I'll probably stick with it. Working on tests and fixing the error message still.

We had been lumping #3109 and #3110 together in discussions, but they're actually quite separate. This only fixes #3110. I will move on the #3109 next once this is out of draft.

@fadimounir
Copy link

/cc @sbomer

@fadimounir
Copy link

Can we now delete this:

// TEMP LOGIC - SDK Should provide correct list - When fixing https://github.com/dotnet/sdk/issues/3110, delete

@nguerrera
Copy link
Contributor Author

Can we now delete this:

No. We need #3109 for that. It appears the comment is referencing the wrong bug. I'll fix that.

@nguerrera nguerrera requested review from dsplaisted and a team June 12, 2019 22:09
@nguerrera nguerrera marked this pull request as ready for review June 12, 2019 22:09
@nguerrera nguerrera requested a review from peterhuene June 12, 2019 22:13
@nguerrera
Copy link
Contributor Author

Went ahead and marked this ready for review. If we decide to take a fundamentally different approach, I'll close and start fresh on that.

@nguerrera
Copy link
Contributor Author

@dsplaisted @fadimounir @dotnet/dotnet-cli Ping for review.

@fadimounir
Copy link

<!-- TODO: BUG - FIX ImplementationAssemblies to take managed implementation assemblies to use as crossgen references -->

This comment can be deleted, and replace ImplementationAssemblies="@(ResolvedFileToPublish)" with ImplementationAssemblies="@(_ReadyToRunImplementationAssemblies)" a few lines below


Refers to: src/Tasks/Microsoft.NET.Build.Tasks/targets/Microsoft.NET.Publish.targets:321 in 275920f. [](commit_id = 275920f, deletion_comment = False)

Copy link

@fadimounir fadimounir left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The _CreateR2RSymbols target needs to be fixed to use the _ReadyToRunImplementationAssemblies list

Copy link

@fadimounir fadimounir left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@nguerrera nguerrera merged commit 752d6e5 into dotnet:master Jun 18, 2019
@nguerrera nguerrera deleted the r2r-fdd branch June 18, 2019 22:48
dsplaisted pushed a commit to dsplaisted/sdk that referenced this pull request Feb 19, 2020
…026.1 (dotnet#3326)

- Microsoft.NET.Sdk.Web - 3.1.100-preview2.19526.1
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Resolve runtime pack assets for crossgen even if app is framework-dependent
4 participants