Update ValidateExecutableReferences with new schema #19786
Conversation
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
|
This is failing a bunch of tests on full framework, presumably because it's running on an older version of MSBuild which doesn't have dotnet/msbuild#6699. Can we condition setting |
|
I'm confused—doesn't the SDK come with its own MSBuild? I would've thought that would mean that if your SDK is new enough to have this change, it would be new enough to have 6699, too. Had the main I based this on not been updated with 6699 yet or something? |
| @@ -1089,6 +1093,7 @@ Copyright (c) .NET Foundation. All rights reserved. | |||
| SelfContained="$(SelfContained)" | |||
| IsExecutable="$(_IsExecutable)" | |||
| ReferencedProjects="@(_MSBuildProjectReferenceExistent)" | |||
| MSBuildVersion="$(MSBuildVersion)" | |||
There was a problem hiding this comment.
Could we pass the value of _UseAttributeForTargetFrameworkInfoPropertyNames in here instead of the MSBuild version? Then we wouldn't have two places where we're checking whether we're on version 17 or higher.
|
@dsplaisted should this be in RC2? |
Yes, I would go ahead and merge it. |
|
@Forgind , can you prep for RC2 then? |
Opts into using the new schema and looks for a TF with its first attribute equal to nearestTargetFramework.
There are multiple ways to do this, so I'm open to suggested improvements 🙂