Append instead of override DefaultExcludesInProjectFolder #19512
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This fixes a typo which causes DefaultExcludesInProjectFolder to override existing values instead of appending to the existing value.
|
Fixed in #24063 |
ViktorHofer
pushed a commit
that referenced
this pull request
May 7, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The definition of
DefaultExcludesInProjectFolderin Microsoft.NET.Sdk.DefaultItems.targets overrides theexisting definition of the property due to a typo that references
DefaultItemExcludesInProjectFolderinsteadof
DefaultExcludesInProjectFolder.This appears to have been introduced in #803 where the property was renamed from
DefaultItemExcludesInProjectFoldertoDefaultExcludesInProjectFolderbut the inner reference was notupdated.