Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Generate suggestions for workloads to install #17512

Merged

Conversation

dsplaisted
Copy link
Member

Finishes #13849

@dotnet-issue-labeler
Copy link

I couldn't figure out the best area label to add to this PR. If you have write-permissions please help me learn by adding exactly one area label.

@dsplaisted dsplaisted force-pushed the workload-suggestions branch 2 times, most recently from 5b2cda5 to 68f6072 Compare May 8, 2021 01:21
@marcpopMSFT marcpopMSFT requested a review from wli3 May 12, 2021 21:14
@dsplaisted dsplaisted changed the base branch from main to release/6.0.1xx-preview5 May 16, 2021 15:45
@dsplaisted
Copy link
Member Author

@dotnet/dotnet-cli I've retargeted this to preview 5, and updated the error message. Now it looks like this:

c:\git\dotnet-sdk2\artifacts\bin\redist\Debug\dotnet\sdk\6.0.100-dev\Sdks\Microsoft.NET.Sdk\targets\Microsoft.NET.Sdk.ImportWorkloads.targets(33,5): error NETSDK1147: To build this project, the following workloads must be installed: microsoft-android-sdk-full [c:\git\dotnet-sdk2\artifacts\tmp\Debug\It_should_fai---14415423\WorkloadTest\WorkloadTest.csproj]
c:\git\dotnet-sdk2\artifacts\bin\redist\Debug\dotnet\sdk\6.0.100-dev\Sdks\Microsoft.NET.Sdk\targets\Microsoft.NET.Sdk.ImportWorkloads.targets(33,5): error NETSDK1147: To install these workloads, run the following command: dotnet workload install microsoft-android-sdk-full [c:\git\dotnet-sdk2\artifacts\tmp\Debug\It_should_fai---14415423\WorkloadTest\WorkloadTest.csproj]

@dsplaisted dsplaisted merged commit 1beaa14 into dotnet:release/6.0.1xx-preview5 May 17, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants