Use new HostModel APIs #10849
Merged
Use new HostModel APIs #10849
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Update GenerateBundle task and a few others to use the new APIs in HostModel intruduced by dotnet/runtime#33413. This change is in preparation for moving to new PublishSingleFile semantics in .net 5. In GenerateBundle task, the SDK constructs the bundler with `BundleAllContent` option for all builds. This keeps the behavior of PublishSingleFile unchanged until Host/Runtime components of the feature are ready.
swaroop-sridhar
requested review from
dsplaisted and
wli3
and removed request for
dsplaisted
dsplaisted
approved these changes
Mar 12, 2020
wli3
added
auto-merge
|
Hello @wli3! Because this pull request has the p.s. you can customize the way I help with merging this pull request, such as holding this pull request until a specific person approves. Simply @mention me (
|
ghost
merged commit
swaroop-sridhar
added a commit
to swaroop-sridhar/runtime
that referenced
this pull request
Mar 13, 2020
Some depricated APIs were maintained in dotnet#33413 so that SDK build is green. Now that the SDK is updated dotnet/sdk#10849, remove the unused APIs. Also move out a test-only methods from the product to the test helpers.
swaroop-sridhar
added a commit
to dotnet/runtime
that referenced
this pull request
Mar 13, 2020
Some depricated APIs were maintained in #33413 so that SDK build is green. Now that the SDK is updated dotnet/sdk#10849, remove the unused APIs. Also move out a test-only methods from the product to the test helpers.
This pull request was closed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Update GenerateBundle task and a few others to use the new APIs in HostModel intruduced by dotnet/runtime#33413.
This change is in preparation for moving to new PublishSingleFile semantics in .net 5.
In GenerateBundle task, the SDK constructs the bundler with
BundleAllContentoption for all builds.This keeps the behavior of PublishSingleFile unchanged until Host/Runtime components of the feature are ready.