Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ResolvePackageDependencies does not handle native winmds correctly #568

Closed
ericstj opened this issue Dec 30, 2016 · 6 comments
Closed

ResolvePackageDependencies does not handle native winmds correctly #568

ericstj opened this issue Dec 30, 2016 · 6 comments

Comments

@ericstj
Copy link
Member

ericstj commented Dec 30, 2016

See https://github.com/NuGet/NuGet.BuildTasks/blob/4a57a0ef4bee31f122d50a39fe3dddd4ca03fb07/src/Microsoft.NuGet.Build.Tasks/ResolveNuGetPackageAssets.cs#L380 for an example of what needs to be done.

/cc @jasonmalinowski @natidea @nguerrera

@ericstj
Copy link
Member Author

ericstj commented Dec 30, 2016

For that matter you should probably examine all the differences between ResolveNuGetPackageAssets and ResolvePackageDependencies to make sure we aren't missing any functionality...

@natidea
Copy link
Contributor

natidea commented Jan 3, 2017

Thanks for the note @ericstj . When we designed ResolvePackageDependencies task, we intentionally limited its scope to simply raising the assets file to MSBuild items that can be further manipulated downstream. In other words, the goal is to eventually replace ResolveNuGetPackageAssets with multiple smaller tasks that compose better. (We have also initially limited our scope to functionality needed for the next .NET Core tooling release.)

As an example, ResolveNuGetPackageAssets has some functionality for producing content assets and handling preprocessor values. In the SDK, we moved this functionality to a downstream task and a separate MSBuild target.

What is the timeframe in which support for native winmds is needed? I think the correct solution will involve new tasks/targets, and probably a new targets file.

/cc @srivatsn @davkean

@srivatsn
Copy link
Contributor

srivatsn commented Jan 3, 2017

I assume we'll need this for UWP projects to be SDK-based post 1.0

@ericstj
Copy link
Member Author

ericstj commented Jan 4, 2017

You'll need this when you want UWP to move from project.json to PackageReference.

mmitche pushed a commit to mmitche/sdk that referenced this issue Jun 5, 2020
Copy link
Contributor

Due to lack of recent activity, this issue has been labeled as 'stale'. It will be closed if no further activity occurs within 30 more days. Any new comment will remove the label.

@github-actions github-actions bot added the stale label Apr 25, 2024
Copy link
Contributor

This issue will now be closed since it has been labeled 'stale' without activity for 30 days.

@github-actions github-actions bot closed this as not planned Won't fix, can't repro, duplicate, stale May 26, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants