Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Generate AssemblyMetadataAttribute when serviceable is true #490

Closed
natemcmaster opened this issue Dec 13, 2016 · 1 comment
Closed

Generate AssemblyMetadataAttribute when serviceable is true #490

natemcmaster opened this issue Dec 13, 2016 · 1 comment
Labels
Bug
Milestone
Backlog

Comments

@natemcmaster
Copy link
Contributor

NuGet supports the <Serviceable>true</Serviceable> property. IIUC packages using this should also be compiled with [assembly: AssemblyMetadata("Serviceable", "True")]. Can auto generate this assembly attribute when the MSbuild property is set?
@natemcmaster natemcmaster mentioned this issue Dec 16, 2016
Closed
16 tasks
@srivatsn srivatsn added the Bug label Dec 21, 2016
@srivatsn srivatsn added this to the Unknown milestone Dec 21, 2016
@natemcmaster
Copy link
Contributor Author

I've since learned that Serviceable is a Microsoft-internal kind of thing. We probably don't need this i in the SDK and have implemented this in our own targets. Closing as we don't need it.

mmitche pushed a commit to mmitche/sdk that referenced this issue Jun 5, 2020
@dotnet-maestro
Update dependencies from https://github.com/dotnet/arcade build 20190…
f5ee6e1 
…215.1 (dotnet#490)

This change updates the following dependencies
- Microsoft.DotNet.Arcade.Sdk - 1.0.0-beta.19115.1
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Bug
Projects
None yet
Milestone
Backlog
Development

No branches or pull requests
2 participants
@srivatsn @natemcmaster