-
Notifications
You must be signed in to change notification settings - Fork 1.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Get platform manifest and conflict resolution data from targeting packs or runtime packs if appropriate #2933
Comments
The platform manifest is meant to be used for trimming framework-dependent apps. I don't think runtime packs are the right place for this because those packs are mean for self-contained deployments and according to @nguerrera are deliberately not part of the offline experience. Also, I don't think the platform manifest should be necessary for self-contained -- isn't the idea that for self-contained you copy the whole folder from the runtime pack into the app output? Targeting pack seems more appropriate for platform manifest. |
@dsplaisted is this one still in progress? |
Work is done for targeting packs. We still need to do the work for runtime packs but runtime packs don't have platform manifests yet. |
As to Nate's comment, the platform manifest is used for framework-dependent apps to trim dependencies that are already included in the shared framework. For self-contained apps, if there is a dependency which is part of the Framework, we still need to decide which asset to use. In either case, the platform manifest can provide the version information for conflict resolution to make these decisions. |
Closing this in favor of https://github.com/dotnet/cli/issues/10581 and https://github.com/dotnet/cli/issues/10442 |
Looking back at this, I don't think we need the platform manifest for runtime packs, as the runtime list provides the same information. |
….2 (#2933) - Microsoft.DotNet.Cli.Runtime - 5.0.100-alpha1.19468.2
For .NET Core 2.x, the
Microsoft.NETCore.App
package includes a platform manifest .txt file as well asPackageConflictOverrides
MSBuild items for conflict resolution. For .NET Core 3.0, these should come from the targeting pack for framework dependent apps, and from the runtime pack for self-contained apps.This means that both targeting packs and runtime packs need to include this data, and the SDK needs to use the data from the appropriate type of pack depending on whether the app is self-contained or not.
The text was updated successfully, but these errors were encountered: