-
Notifications
You must be signed in to change notification settings - Fork 1.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
System.Net.Http and System.IO.Compression .NET Standard facades need to be included when targeting .NET 4.7.1 #1647
Comments
@dsplaisted @nguerrera as @JPhilC reported, this may also be needed for |
This has now been fixed. |
Updated SharpCompress uses .Net Standard 2.0 and causing issues. To resolve issues caused by .Net Standard 2.0 reference, upgrade .Net Framework. (System.IO.Compression, System.Net.Http issue) But System.IO.Compress is still unusable, so remove it. dotnet/sdk#1647
Hi. I have had trouble getting a project working for reasons surrounding these binding issues. I wanted to add a comment now that the project seems to work: it was not simple to get it working, and I had to find the right recipe.
VS would not build, and eventually I get "you need to reference System.Configuration.ConfigurationManager 4.0.0.0". --- Version is interesting? When I add to the Framework project, NuGet ConfigurationManager 4.4.1, that project file now contains:
... Which are odd version numbers? Eventually I had to also add
And now it is working. And there is another similar thing in the same project:
... And I added NuGet System.ComponentModel.Annotations 4.4.1. And the Framework project file now contains:
I just wanted to add a comment because it was not simple to get it working: if you do or don't add the AutoGenerateBindingRedirects, and do or don't add the NuGet references, you get different failures, and different suggestions. I had to come to this recipe to see it working. |
Unable to work around upstream breakage due to OOB upgrade of netfx package. ref: dotnet/sdk#1647
Fixed in which version? Could you please elaborate and clarify? |
I am not having issues anymore myself; but its because in ALL possible projects, I migrated to the "new" project format --- where the "new" format is like:
Where in my
... They may be actually set that way in this project format by default; but I ensure that all projects, for any target, do get set up that way consistently. And I do that for all target framework types; and it's important that an e.g.
... And, for sure in these projects I also either include or explicitly define If there is a single deviation from this recipe in a large solution, then you can actually begin to see cryptic failures in transitive projects that take a moment to track down where the configuration breaks the build. You can have a very hard time with an error message from a second or third branched referenced project, from a mis-configuration back up the project reference tree and back out again to a different transitive reference! |
@eriawan VS 15.6. SDK will be 2.1.100. |
.NET 4.7.1 ships with support for the .NET Standard 2.0 APIs, as well as the necessary facades. So it's not supposed to need any facades injected by the
ImplicitlyExpandNETStandardFacades
target.However, the in-box assembly versions of System.Net.Http and System.IO.Compression are less than the OOB and facade versions of those libraries. This will be fixed in .NET 4.7.2, however for 4.7.1, we still need to inject just those two facades as necessary.
The text was updated successfully, but these errors were encountered: