Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Generate target platform assembly attributes #11239

Closed
dsplaisted opened this issue Apr 10, 2020 · 3 comments · Fixed by #11499
Closed

Generate target platform assembly attributes #11239

dsplaisted opened this issue Apr 10, 2020 · 3 comments · Fixed by #11499
Assignees
@wli3
Milestone
5.0.1xx

Comments

@dsplaisted
Copy link
Member

dsplaisted commented Apr 10, 2020 •
edited by wli3
Loading

If the TargetPlatformIdentifier is set, the .NET SDK should generate assembly attributes for the target platform version, as well as the OSMinimumVersion. See this spec: https://github.com/dotnet/designs/blob/master/accepted/2020/minimum-os-version/minimum-os-version.md

We can also include in this setting the MinimumOSPlatform to the TargetPlatformVersion if it's not otherwise defined.
@dsplaisted dsplaisted added this to the 5.0.1xx milestone Apr 10, 2020
@dsplaisted dsplaisted mentioned this issue Apr 10, 2020
Closed
25 tasks
@wli3 wli3 mentioned this issue Apr 27, 2020
Closed
@wli3
Copy link

wli3 commented Apr 27, 2020 •
edited
Loading

Partially blocked by dotnet/runtime#33331

I can write most of the code. But not to merge it

@wli3 wli3 mentioned this issue Apr 30, 2020
Merged
@wli3
Copy link

wli3 commented Jul 7, 2020 •
edited
Loading

Rename MinimumPlatformVersion -> MinimumOSPlatform

@wli3
Copy link

wli3 commented Jul 8, 2020

Being blocked by dotnet/installer#7943

Review is done just need the runtime type to flow in

@ghost ghost closed this as completed in #11499 Jul 10, 2020
wli3 pushed a commit to wli3/sdk that referenced this issue Jul 21, 2020
@johnbeisner
Merge pull request dotnet#11239 from johnbeisner/UpdateDebianDockerFi…
2c08773 
…le2.1.7xx

release/2.1.7xx: Update debain jessie image
@wli3 wli3 mentioned this issue Oct 16, 2020
Closed
This issue was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@wli3 wli3

Labels
None yet
Projects
None yet
Milestone
5.0.1xx
Development

Successfully merging a pull request may close this issue.

Generate target platform assembly attributes wli3/sdk
2 participants
@dsplaisted @wli3