Make XmlSerializer work with NativeAOT #593
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Force the reflection-only code paths that don't Reflection.Emit.
MichalStrehovsky
added
the
area-NativeAOT-coreclr
jkotas
reviewed
Jan 26, 2021
|
|
||
| if (Mode == SerializationMode.ReflectionOnly) | ||
| { | ||
| return; |
There was a problem hiding this comment.
Do we need to also execute GetTopLevelMapping at the very bottom of the method in ReflectionOnly mode?
There was a problem hiding this comment.
jkotas
reviewed
Jan 26, 2021
| { | ||
| return; | ||
| } | ||
|
|
||
| _tempAssembly = s_cache[defaultNamespace, type]; | ||
| if (_tempAssembly == null) |
There was a problem hiding this comment.
Do we need to fix XmlSerializer(XmlTypeMapping xmlTypeMapping) constructor in the same way?
There was a problem hiding this comment.
Welp, I haven't done a full audit of what were all of the deleted ifdefs doing. This is more of an emergency fix to see what else the partner team is going to hit. We could file an issue to do a full audit.
jkotas
approved these changes
Jan 26, 2021
eerhardt
added a commit
to eerhardt/runtime
that referenced
this pull request
Sep 21, 2021
Add more checks to XmlSerializer to check the SerializationMode. Don't try to use Reflection.Emit if the SerializationMode is ReflectionOnly. These changes were ported from * dotnet/runtimelab#593 * dotnet/runtimelab#600 Fix dotnet#59167
eerhardt
added a commit
to dotnet/runtime
that referenced
this pull request
Sep 23, 2021
* XmlSerializer support for IsDynamicCodeSupported=false Add more checks to XmlSerializer to check the SerializationMode. Don't try to use Reflection.Emit if the SerializationMode is ReflectionOnly. These changes were ported from * dotnet/runtimelab#593 * dotnet/runtimelab#600 Fix #59167 * Fix a bug in XmlSerializer.CanDeserialize when in ReflectionOnly mode. * Port UAP code for CanDeserialize * PR feedback * Add a linker test to ensure linker option '--enable-opt sealer' works when IsDynamicCodeSupported==false.
github-actions bot
pushed a commit
to dotnet/runtime
that referenced
this pull request
Sep 23, 2021
Add more checks to XmlSerializer to check the SerializationMode. Don't try to use Reflection.Emit if the SerializationMode is ReflectionOnly. These changes were ported from * dotnet/runtimelab#593 * dotnet/runtimelab#600 Fix #59167
Anipik
pushed a commit
to dotnet/runtime
that referenced
this pull request
Sep 24, 2021
…lse (#59507) * XmlSerializer support for IsDynamicCodeSupported=false Add more checks to XmlSerializer to check the SerializationMode. Don't try to use Reflection.Emit if the SerializationMode is ReflectionOnly. These changes were ported from * dotnet/runtimelab#593 * dotnet/runtimelab#600 Fix #59167 * Fix a bug in XmlSerializer.CanDeserialize when in ReflectionOnly mode. * Port UAP code for CanDeserialize * PR feedback * Add a linker test to ensure linker option '--enable-opt sealer' works when IsDynamicCodeSupported==false. Co-authored-by: Eric Erhardt <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Force the reflection-only code paths that don't Reflection.Emit.