Update SafeHandle codegen to match the approved API. #570
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jkoritzinsky
added
the
area-DllImportGenerator
stephentoub
reviewed
Jan 19, 2021
DllImportGenerator/DllImportGenerator/Marshalling/SafeHandleMarshaller.cs
Outdated
Show resolved
Hide resolved
… the generated code.
| @@ -82,9 +82,9 @@ private TypePositionInfo() | |||
|
|
|||
| public MarshallingInfo MarshallingAttributeInfo { get; init; } | |||
|
|
|||
| public static TypePositionInfo CreateForParameter(IParameterSymbol paramSymbol, DefaultMarshallingInfo defaultInfo, Compilation compilation, GeneratorDiagnostics diagnostics) | |||
| public static TypePositionInfo CreateForParameter(IParameterSymbol paramSymbol, DefaultMarshallingInfo defaultInfo, Compilation compilation, GeneratorDiagnostics diagnostics, INamedTypeSymbol scopeSymbol) | |||
There was a problem hiding this comment.
Ugh. These two functions (i.e. CreateForParameter and CreateForType) are hideous... Let's make a mental note that they should not be exposed as is when we enable extending the source generator.
/cc @elinor-fung
elinor-fung
reviewed
Jan 20, 2021
Remove the base list from the containing types so we don't need to handle correctly using fully-qualified names for all the types.
elinor-fung
approved these changes
Jan 20, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Update SafeHandle marshalling to use Activator.CreateInstance and InitHandle.