[NativeAOT-LLVM] Implement most of globalization #2490
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Package the globalization data into a static library and use that at user link time.
SingleAccretion
changed the title
SingleAccretion
commented
Jan 18, 2024
SingleAccretion
commented
Jan 18, 2024
Comment on lines
+33
to
+44
| <Target Name="BuildNativeCommon" | ||
| DependsOnTargets="GenerateNativeVersionFile"> | ||
| <ItemGroup> | ||
| <_IcuArtifacts Condition="'$(_IcuDir)' != '' and '$(TargetsAppleMobile)' != 'true'" | ||
| Include="$(_IcuDir)/lib/libicuuc.a; | ||
| $(_IcuDir)/lib/libicui18n.a; | ||
| $(_IcuDir)/lib/libicudata.a; | ||
| $(_IcuDir)/lib/*.dat" /> | ||
| </ItemGroup> | ||
|
|
||
| <Copy SourceFiles="@(_IcuArtifacts)" DestinationFolder="$([MSBuild]::NormalizeDirectory('$(ArtifactsBinDir)', 'native', '$(_BuildNativeOutConfig)'))" SkipUnchangedFiles="true" /> | ||
| </Target> |
There was a problem hiding this comment.
I hope to upstream changes to this file, and perhaps remove the duplicate copying done by wasm.proj/wasi.proj.
SingleAccretion
commented
Jan 18, 2024
Comment on lines
565
to
566
| <!-- We want to put 'warn-unresolved-symbols' here, but wasm-ld crashs on that. Oops. --> | ||
| <CustomLinkerArg Include="-Wl,--unresolved-symbols=ignore-all" /> |
There was a problem hiding this comment.
Will have to debug and file a bug on LLVM about this (if it hasn't been fixed already)...
Edit: there is one already - llvm/llvm-project#53987.
jkotas
added
the
area-NativeAOT-LLVM
|
@dotnet/nativeaot-llvm |
|
FYI: Likely conflict with dotnet/runtime#97216 |
In ".align X", "X" is a power of two. Also, use a zero-sized end symbol. Symbols need not have > 0 sizes.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
How this works:
icudt.datand friends).libSystem.Native.aand friends.Overall few changes are required, but this is notably different from what Mono does, which runs some code at runtime startup that locates the ICU data (either by downloading it, or from the file system, or from the single-file bundle). It means that our
DotNetJsApicase will still use the static data, but do that startup thing too. We can cross the bridge of reconciling these two approaches onceDotNetJsApigets a little more mature.Another part not yet working is the time zone data, which uses Mono-specific bundling mechanism. It is the last undefined symbol for
HelloWasmtargeting WASI, I will tackle it separately (in #2491).