Support implicit blittability for structs declared in and not exposed outside of the current compilation. #1126
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… outside of the current compilation.
…elab into internal-implicit-blittable
jkoritzinsky
added
the
area-DllImportGenerator
| public static bool HasOnlyBlittableFields(this ITypeSymbol type) => HasOnlyBlittableFields(type, new HashSet<ITypeSymbol>(SymbolEqualityComparer.Default)); | ||
| #pragma warning restore RS1024 // Compare symbols correctly | ||
|
|
||
| private static bool HasOnlyBlittableFields(this ITypeSymbol type, HashSet<ITypeSymbol> seenTypes) |
There was a problem hiding this comment.
Do me a favor here and pass a recursion counter - when it reaches 0 we throw. Alternatively this could be converted to use a Stack<T> and turned into an iterative solution.
There was a problem hiding this comment.
Same protection for IsConsideredBlittable.
There was a problem hiding this comment.
As we discussed offline, I think we should leave Stack-overflow protection due to too many nested structs to the Roslyn compiler infrastructure.
…e sure we're handling our recursion check correctly.
jkoritzinsky
force-pushed
the
internal-implicit-blittable
branch
from
070f1e7 to
505a2a2
Compare
elinor-fung
approved these changes
May 18, 2021
jkoritzinsky
added a commit
to jkoritzinsky/runtime
that referenced
this pull request
Sep 20, 2021
… outside of the current compilation. (dotnet/runtimelab#1126) Commit migrated from dotnet/runtimelab@51d9ad8
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Also significantly increase our test coverage for generic blittable types as they're another area nearby and something I hadn't added a ton of tests for originally.
Fixes #1125