-
Notifications
You must be signed in to change notification settings - Fork 4.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Implement Swift lowering algorithm in the CoreCLR type system #99438
Implement Swift lowering algorithm in the CoreCLR type system #99438
Conversation
…s of non-opaque types and to merge opaque intervals
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, but you may want to get review from someone more familiar with the VM side.
I've added a small fix here for the NativeAOT implementation that we discussed offline. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I get the statement about contract. I don't think it is all that obvious the contract or expectations here. The 4 count is used in a few places and I replaced one, but aside from the case where byReference = true
the split rules aren't clear up front, which is what I normally like to see. As long as the JIT team has clear expectations on their side for the ABI I'm good.
I assume tests will come with the JIT?
Yep the JIT PR will add the test suite. I'll refactor out the max size into a constant. |
This PR finishes out the implementations of the algorithm for RyuJIT-compatible type systems.
This does not update the JIT-EE interface to hook up the new function (@jakobbotsch has already made the JIT-EE change in his branch, so I don't want to conflict with that).