Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve perf of ActivatorUtilities.CreateInstance() by avoiding an alloc per ctor #99321

Closed
wants to merge 2 commits into from

Merge branch 'main' into AU.CreateInstancePerf

b45c60f
Select commit
Loading
Failed to load commit list.
Closed

Improve perf of ActivatorUtilities.CreateInstance() by avoiding an alloc per ctor #99321

Merge branch 'main' into AU.CreateInstancePerf
b45c60f
Select commit
Loading
Failed to load commit list.
Azure Pipelines / runtime (Build windows-x86 Release Libraries_NET48) failed Mar 5, 2024 in 6m 21s

Build windows-x86 Release Libraries_NET48 failed

13 errors / 0 warnings

Annotations

Check failure on line 401 in src\libraries\System.Text.Json\tests\System.Text.Json.Tests\JsonTestHelper.cs

See this annotation in the file changed.

@azure-pipelines azure-pipelines / runtime (Build windows-x86 Release Libraries_NET48)

src\libraries\System.Text.Json\tests\System.Text.Json.Tests\JsonTestHelper.cs#L401 

src\libraries\System.Text.Json\tests\System.Text.Json.Tests\JsonTestHelper.cs(401,33): error CA2265: (NETCORE_ENGINEERING_TELEMETRY=Build) Comparing a span to 'default' might not do what you intended, make the code more explicit by checking 'IsEmpty' (https://learn.microsoft.com/dotnet/fundamentals/code-analysis/quality-rules/ca2265)

Check failure on line 414 in src\libraries\System.Text.Json\tests\System.Text.Json.Tests\JsonTestHelper.cs

See this annotation in the file changed.

@azure-pipelines azure-pipelines / runtime (Build windows-x86 Release Libraries_NET48)

src\libraries\System.Text.Json\tests\System.Text.Json.Tests\JsonTestHelper.cs#L414 

src\libraries\System.Text.Json\tests\System.Text.Json.Tests\JsonTestHelper.cs(414,38): error CA2265: (NETCORE_ENGINEERING_TELEMETRY=Build) Comparing a span to 'default' might not do what you intended, make the code more explicit by checking 'IsEmpty' (https://learn.microsoft.com/dotnet/fundamentals/code-analysis/quality-rules/ca2265)

Check failure on line 1092 in src\libraries\System.Text.Json\tests\System.Text.Json.Tests\Utf8JsonReaderTests.MultiSegment.cs

See this annotation in the file changed.

@azure-pipelines azure-pipelines / runtime (Build windows-x86 Release Libraries_NET48)

src\libraries\System.Text.Json\tests\System.Text.Json.Tests\Utf8JsonReaderTests.MultiSegment.cs#L1092 

src\libraries\System.Text.Json\tests\System.Text.Json.Tests\Utf8JsonReaderTests.MultiSegment.cs(1092,37): error CA2265: (NETCORE_ENGINEERING_TELEMETRY=Build) Comparing a span to 'default' might not do what you intended, make the code more explicit by checking 'IsEmpty' (https://learn.microsoft.com/dotnet/fundamentals/code-analysis/quality-rules/ca2265)

Check failure on line 1115 in src\libraries\System.Text.Json\tests\System.Text.Json.Tests\Utf8JsonReaderTests.MultiSegment.cs

See this annotation in the file changed.

@azure-pipelines azure-pipelines / runtime (Build windows-x86 Release Libraries_NET48)

src\libraries\System.Text.Json\tests\System.Text.Json.Tests\Utf8JsonReaderTests.MultiSegment.cs#L1115 

src\libraries\System.Text.Json\tests\System.Text.Json.Tests\Utf8JsonReaderTests.MultiSegment.cs(1115,37): error CA2265: (NETCORE_ENGINEERING_TELEMETRY=Build) Comparing a span to 'default' might not do what you intended, make the code more explicit by checking 'IsEmpty' (https://learn.microsoft.com/dotnet/fundamentals/code-analysis/quality-rules/ca2265)

Check failure on line 1161 in src\libraries\System.Text.Json\tests\System.Text.Json.Tests\Utf8JsonReaderTests.MultiSegment.cs

See this annotation in the file changed.

@azure-pipelines azure-pipelines / runtime (Build windows-x86 Release Libraries_NET48)

src\libraries\System.Text.Json\tests\System.Text.Json.Tests\Utf8JsonReaderTests.MultiSegment.cs#L1161 

src\libraries\System.Text.Json\tests\System.Text.Json.Tests\Utf8JsonReaderTests.MultiSegment.cs(1161,37): error CA2265: (NETCORE_ENGINEERING_TELEMETRY=Build) Comparing a span to 'default' might not do what you intended, make the code more explicit by checking 'IsEmpty' (https://learn.microsoft.com/dotnet/fundamentals/code-analysis/quality-rules/ca2265)
View more details on Azure Pipelines