Do not compare Span<T> with null #98958
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
assigned 
buyaa-n
requested review from
stephentoub
and removed request for
MichalStrehovsky
|
Tagging subscribers to this area: @dotnet/area-meta Issue DetailsFix warnings found with Do not compare Span To null analyzer that @CollinAlpert is implementing. The analyzer is not merged yet, but when it is merged and when the build flows to runtime it would fail the build as the analyzer severity is Also there is 20 hits better to be solved with dedicated PR than codeflow PRs, and needs better review Learn more form the issue
|
.../Common/src/Interop/OSX/System.Security.Cryptography.Native.Apple/Interop.SecKeyRef.macOS.cs
Outdated
Show resolved
Hide resolved
buyaa-n
commented
Feb 27, 2024
src/libraries/System.IO.FileSystem.Watcher/src/System/IO/FileSystemWatcher.Linux.cs
Outdated
Show resolved
Hide resolved
…ystemWatcher.Linux.cs
buyaa-n
commented
Feb 27, 2024
buyaa-n
commented
Feb 27, 2024
src/libraries/System.Net.Primitives/src/System/Net/IPAddress.cs
Outdated
Show resolved
Hide resolved
stephentoub
reviewed
Feb 27, 2024
src/libraries/System.IO.Packaging/src/System/IO/Packaging/ContentType.cs
Outdated
Show resolved
Hide resolved
stephentoub
reviewed
Feb 27, 2024
src/libraries/System.Net.Primitives/src/System/Net/IPAddress.cs
Outdated
Show resolved
Hide resolved
stephentoub
reviewed
Feb 27, 2024
src/libraries/System.Net.Primitives/src/System/Net/IPAddressParser.cs
Outdated
Show resolved
Hide resolved
stephentoub
reviewed
Feb 27, 2024
src/libraries/System.Net.Sockets/src/System/Net/Sockets/SocketPal.Unix.cs
Outdated
Show resolved
Hide resolved
stephentoub
reviewed
Feb 27, 2024
src/libraries/System.Net.Sockets/src/System/Net/Sockets/SocketPal.Unix.cs
Outdated
Show resolved
Hide resolved
stephentoub
reviewed
Feb 27, 2024
src/libraries/System.Private.CoreLib/src/System/Globalization/TimeSpanFormat.cs
Outdated
Show resolved
Hide resolved
stephentoub
reviewed
Feb 27, 2024
src/libraries/System.Private.CoreLib/src/System/Number.Formatting.cs
Outdated
Show resolved
Hide resolved
stephentoub
reviewed
Feb 27, 2024
src/libraries/System.Private.CoreLib/src/System/Number.Formatting.cs
Outdated
Show resolved
Hide resolved
stephentoub
reviewed
Feb 27, 2024
src/libraries/System.Security.Cryptography/src/System/Security/Cryptography/HashProviderCng.cs
Show resolved
Hide resolved
stephentoub
reviewed
Feb 27, 2024
...m.Security.Cryptography/src/System/Security/Cryptography/X509Certificates/X500NameEncoder.cs
Outdated
Show resolved
Hide resolved
Co-authored-by: Stephen Toub <[email protected]>
buyaa-n
commented
Feb 27, 2024
src/libraries/System.IO.Packaging/src/System/IO/Packaging/ContentType.cs
Outdated
Show resolved
Hide resolved
Co-authored-by: Stephen Toub <[email protected]>
vcsjones
reviewed
Feb 27, 2024
.../Common/src/Interop/OSX/System.Security.Cryptography.Native.Apple/Interop.SecKeyRef.macOS.cs
Outdated
Show resolved
Hide resolved
…phy.Native.Apple/Interop.SecKeyRef.macOS.cs Co-authored-by: Kevin Jones <[email protected]>
buyaa-n
requested review from
vcsjones,
stephentoub,
jkotas,
teo-tsirpanis and
MichalPetryka
|
I believe all feedback addressed here, please take another look. |
jkotas
reviewed
Feb 28, 2024
src/libraries/System.IO.FileSystem.Watcher/src/System/IO/FileSystemWatcher.Linux.cs
Outdated
Show resolved
Hide resolved
jkotas
approved these changes
Feb 28, 2024
…ystemWatcher.Linux.cs Co-authored-by: Jan Kotas <[email protected]>
MichalPetryka
approved these changes
Feb 28, 2024
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix warnings found with Do not compare Span To null analyzer that @CollinAlpert is implementing.
The analyzer is not merged yet, but when it is merged and when the build flows to runtime it would fail the build as the analyzer severity is
Warningby default. Better to be fixed before it flows to runtime.Also there is 20 hits better to be solved with dedicated PR than codeflow PRs, and needs better review
Learn more form the issue