Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Arm64 encoding for groups IF_SVE_CW_4A #98762

Merged
merged 2 commits into from
Feb 27, 2024

Conversation

snickolls-arm
Copy link
Contributor

Adds encodings for some SVE mov and sel variants. Matching capstone output:

mov z0.h, p0/m, z30.h
sel z29.d, p15, z28.d, z4.d
mov z5.s, p13/m, z27.s

In the last case mov is aliased with sel.

Contributing towards #94549

@dotnet-issue-labeler dotnet-issue-labeler bot added the area-CodeGen-coreclr CLR JIT compiler in src/coreclr/src/jit and related components such as SuperPMI label Feb 21, 2024
@ghost
Copy link

ghost commented Feb 21, 2024

Tagging subscribers to this area: @JulieLeeMSFT, @jakobbotsch
See info in area-owners.md if you want to be subscribed.

Issue Details

Adds encodings for some SVE mov and sel variants. Matching capstone output:

mov z0.h, p0/m, z30.h
sel z29.d, p15, z28.d, z4.d
mov z5.s, p13/m, z27.s

In the last case mov is aliased with sel.

Contributing towards #94549

Author: snickolls-arm
Assignees: -
Labels:

area-CodeGen-coreclr

Milestone: -

@snickolls-arm
Copy link
Contributor Author

@a74nh @kunalspathak @dotnet/arm64-contrib

@ryujit-bot
Copy link

Diff results for #98762

Throughput diffs

Throughput diffs for linux/arm64 ran on windows/x64

MinOpts (-0.00% to +0.01%)
Collection PDIFF
coreclr_tests.run.linux.arm64.checked.mch +0.01%

Throughput diffs for osx/arm64 ran on windows/x64

MinOpts (-0.01% to +0.01%)
Collection PDIFF
coreclr_tests.run.osx.arm64.checked.mch +0.01%
libraries.pmi.osx.arm64.checked.mch -0.01%

Throughput diffs for windows/arm64 ran on windows/x64

MinOpts (-0.01% to +0.01%)
Collection PDIFF
coreclr_tests.run.windows.arm64.checked.mch +0.01%
libraries.pmi.windows.arm64.checked.mch -0.01%
realworld.run.windows.arm64.checked.mch +0.01%

Details here


Copy link
Contributor

@a74nh a74nh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This LGTM

@huoyaoyuan huoyaoyuan added the arm-sve Work related to arm64 SVE/SVE2 support label Feb 23, 2024
Copy link
Member

@kunalspathak kunalspathak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@kunalspathak
Copy link
Member

@snickolls-arm - do you mind merging the main to make sure superpmi pipelines are clean. The failures were fixed in #98760

@teo-tsirpanis teo-tsirpanis added the community-contribution Indicates that the PR has been added by a community member label Feb 26, 2024
@kunalspathak kunalspathak merged commit ea77071 into dotnet:main Feb 27, 2024
125 of 127 checks passed
@github-actions github-actions bot locked and limited conversation to collaborators Mar 29, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
area-CodeGen-coreclr CLR JIT compiler in src/coreclr/src/jit and related components such as SuperPMI arm-sve Work related to arm64 SVE/SVE2 support community-contribution Indicates that the PR has been added by a community member
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants