[browser][MT] JSType.OneWay fire and forget #98567
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pavelsavara
added
arch-wasm
|
Tagging subscribers to 'arch-wasm': @lewing Issue DetailsThis will be useful for
|
maraf
reviewed
Feb 17, 2024
...aries/System.Runtime.InteropServices.JavaScript/gen/JSImportGenerator/Resources/Strings.resx
Outdated
Show resolved
Hide resolved
pavelsavara
force-pushed
the
browser_mt_oneway
branch
from
5c9990a
to
6d5baef
Compare
This was referenced Feb 17, 2024
pavelsavara
force-pushed
the
browser_mt_oneway
branch
from
6d5baef
to
85801bf
Compare
|
/azp run runtime-wasm |
|
Azure Pipelines successfully started running 1 pipeline(s). |
This was referenced Feb 17, 2024
pavelsavara
force-pushed
the
browser_mt_oneway
branch
from
5ea4c20
to
3e4e9a5
Compare
|
/azp run runtime-wasm |
|
Azure Pipelines successfully started running 1 pipeline(s). |
|
/azp run runtime-wasm |
|
Azure Pipelines successfully started running 1 pipeline(s). |
|
/azp run runtime-wasm |
|
Azure Pipelines successfully started running 1 pipeline(s). |
pavelsavara
requested review from
lewing,
thaystg,
ilonatommy,
lambdageek and
vargaz
as code owners
maraf
approved these changes
Feb 18, 2024
kg
reviewed
Feb 18, 2024
src/libraries/System.Runtime.InteropServices.JavaScript/gen/JSImportGenerator/JSTypeFlags.cs
Show resolved
Hide resolved
kg
reviewed
Feb 18, 2024
...teropServices.JavaScript.UnitTests/System/Runtime/InteropServices/JavaScript/JSExportTest.cs
Show resolved
Hide resolved
kg
reviewed
Feb 18, 2024
...vices.JavaScript.UnitTests/System/Runtime/InteropServices/JavaScript/JavaScriptTestHelper.cs
Show resolved
Hide resolved
kg
reviewed
Feb 18, 2024
kg
reviewed
Feb 18, 2024
kg
reviewed
Feb 18, 2024
kg
reviewed
Feb 18, 2024
kg
reviewed
Feb 18, 2024
kg
reviewed
Feb 18, 2024
kg
reviewed
Feb 18, 2024
kg
reviewed
Feb 18, 2024
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This will be useful for
beginInvokeDotNetFromJSandendInvokeJSFromDotNetwhich could be fire & forget across threads.There is new API
JSType.OneWaywhich will need API review later.Other changes
signatureandargson allInvokeJSImportvariations.ReceiverShouldFreeto make reasoning easier about who shouldfreetheargson heap.mono_wasm_invoke_methodtomono_wasm_invoke_jsexportand variationsmono_wasm_invoke_importtomono_wasm_invoke_jsimportand variationsmono_wasm_invoke_jsimportmono_threads_wasm_async_run_in_ui_threadand variationsPrep for deputy
JSProxyContext.NativeTIDwhich will be different than current thread when we have deputy thread.mono_wasm_invoke_jsexport_async_postandmono_wasm_invoke_jsexport_async_sendunused for nowinvoke_async_jsexportandinvoke_sync_jsexport, both are synchronous until deputy