-
Notifications
You must be signed in to change notification settings - Fork 4.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[browser] Move reflection from JS to C# #98391
Conversation
Tagging subscribers to 'arch-wasm': @lewing Issue DetailsThis decreases hazard of dealing with managed types in JS. Contributes to #98366
|
/azp run runtime-wasm |
Azure Pipelines successfully started running 1 pipeline(s). |
...ropServices.JavaScript/src/System/Runtime/InteropServices/JavaScript/JSHostImplementation.cs
Outdated
Show resolved
Hide resolved
...ropServices.JavaScript/src/System/Runtime/InteropServices/JavaScript/JSHostImplementation.cs
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me 👍
/azp run runtime-wasm |
Azure Pipelines successfully started running 1 pipeline(s). |
/azp run runtime-wasm |
Azure Pipelines successfully started running 1 pipeline(s). |
I filled #98486 |
Looks like this change increased the cold browser template startup time, probably increased the size. The range is 741c0c8...c34474e Is there anything we can do to improve it? |
I think we should discuss this more, it pulls in a lot more managed code and the long term fix is different. |
We can move it back to C/mono, but call it from C# side. |
I moved it back to C, but called from the managed thread. #98534 Could you please check the perf with this ? @radekdoulik many thanks! |
This decreases hazard of dealing with managed types in JS.
It also reduces the need to
MONO_ENTER_GC_UNSAFE
It will allow to initiate
bind_assembly_exports
from UI to deputy thread.Allocate gc-roots for
monoStringToStringUnsafe
earlier.Contributes to #98366